Skip to content

Conversation

@jpinkney-aws
Copy link
Contributor

Problem

  • When the bearer token updates in the background we never re-notify the language server

Solution

  • update it every 5 minutes as a hack to unblock the pentest

  • Treat all work as PUBLIC. Private feature/x branches will not be squash-merged at release time.
  • Your code changes must meet the guidelines in CONTRIBUTING.md.
  • License: I confirm that my contribution is made under the terms of the Apache 2.0 license.

@jpinkney-aws jpinkney-aws requested a review from a team as a code owner March 14, 2025 18:48
@github-actions
Copy link

  • This pull request modifies code in src/* but no tests were added/updated.
    • Confirm whether tests should be added or ensure the PR description explains why tests are not required.
  • This pull request implements a feat or fix, so it must include a changelog entry (unless the fix is for an unreleased feature). Review the changelog guidelines.
    • Note: beta or "experiment" features that have active users should announce fixes in the changelog.
    • If this is not a feature or fix, use an appropriate type from the title guidelines. For example, telemetry-only changes should use the telemetry type.

Copy link
Contributor

@hayemaxi hayemaxi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should dispose of it on deactivation/exception. Might cause tests or other things to hang later.

@jpinkney-aws
Copy link
Contributor Author

good point, just updated it

@jpinkney-aws jpinkney-aws merged commit 2c9d505 into aws:feature/amazonqLSP Mar 14, 2025
17 checks passed
@jpinkney-aws jpinkney-aws deleted the init-interval branch March 14, 2025 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants