fix(amazonq): Improve responses for saved prompts and workspace rules #6805
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
leigaol
approved these changes
Mar 18, 2025
justinmk3
reviewed
Mar 18, 2025
| if (prompt.filePath.endsWith(promptFileExtension)) { | ||
| if (prompt.relativePath.startsWith(path.join('.amazonq', 'rules'))) { | ||
| return 'rule' | ||
| } else if (prompt.filePath.startsWith(getUserPromptsDirectory())) { |
Contributor
There was a problem hiding this comment.
This condition seems fragile. Was prompt.filePath and getUserPromptsDirectory() normalized? Better to use isInDirectory or similar.
justinmk3
reviewed
Mar 18, 2025
packages/core/src/codewhispererChat/controllers/chat/controller.ts
Outdated
Show resolved
Hide resolved
avi-alpert
force-pushed
the
aalpert/system-prompts-rules
branch
from
9d2ee26 to
5ef5cc7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The system prompt for saved prompts and workspace rules is too vague, users reporting they are sometimes ignored entirely.
Solution
Add system prompt for saved prompt and workspace rules to improve quality of responses
feature/xbranches will not be squash-merged at release time.