-
Notifications
You must be signed in to change notification settings - Fork 749
telemetry(amazonq):Add metric telemetry for /doc #6822
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| this.messenger.sendChatInputEnabled(tabID, false) | ||
| } | ||
| } | ||
| await session.sendDocMetricData(MetricDataOperationName.EndDocGeneration, MetricDataResult.Success) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
won't this always send an EndDocGeneration as success?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If having error during doc generation, it will fall into the catch block and execute finally but skip the rest
followed the same pattern as /dev:
aws-toolkit-vscode/packages/core/src/amazonqFeatureDev/controllers/chat/controller.ts
Line 585 in 4b20c5a
| await session.sendMetricDataTelemetry(MetricDataOperationName.EndCodeGeneration, MetricDataResult.Success) |
Problem
Solution
feature/xbranches will not be squash-merged at release time.