Skip to content

Conversation

@KevinDing1
Copy link
Contributor

@KevinDing1 KevinDing1 commented Mar 20, 2025

Problem

  • This commit introduces metric telemetry for the /doc, which will be triggered during the code generation process. The new telemetry will:
    1. Record successful and failure generation requests
    2. Track failed requests with specific error types
    3. Enable the setup of client monitoring alarms base on the metric data

Solution


  • Treat all work as PUBLIC. Private feature/x branches will not be squash-merged at release time.
  • Your code changes must meet the guidelines in CONTRIBUTING.md.
  • License: I confirm that my contribution is made under the terms of the Apache 2.0 license.

this.messenger.sendChatInputEnabled(tabID, false)
}
}
await session.sendDocMetricData(MetricDataOperationName.EndDocGeneration, MetricDataResult.Success)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

won't this always send an EndDocGeneration as success?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If having error during doc generation, it will fall into the catch block and execute finally but skip the rest
followed the same pattern as /dev:

await session.sendMetricDataTelemetry(MetricDataOperationName.EndCodeGeneration, MetricDataResult.Success)

@KevinDing1 KevinDing1 marked this pull request as ready for review March 28, 2025 14:18
@KevinDing1 KevinDing1 requested a review from a team as a code owner March 28, 2025 14:18
@KevinDing1 KevinDing1 enabled auto-merge March 28, 2025 14:19
@justinmk3 justinmk3 disabled auto-merge March 31, 2025 15:38
@justinmk3 justinmk3 merged commit 8ce5469 into aws:master Mar 31, 2025
30 of 31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants