fix(amazonq): normalize path for /doc scope #6823
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avi-alpert
changed the title
|
Contributor
Author
|
Manually validated fix in windows with vsix from this PR |
vikshe
approved these changes
Mar 25, 2025
KevinDing1
approved these changes
Mar 25, 2025
jpinkney-aws
approved these changes
Mar 25, 2025
Hweinstock
pushed a commit
to Hweinstock/aws-toolkit-vscode
that referenced
this pull request
Mar 26, 2025
## Problem On Windows, if a /doc user changes a folder to a nested subfolder more than one level below the workspace level, the folderPath sent to the API includes backslashes, which results in a `The folder you chose did not contain any source files` error. ## Solution Normalize folderPath before making API request --- - Treat all work as PUBLIC. Private `feature/x` branches will not be squash-merged at release time. - Your code changes must meet the guidelines in [CONTRIBUTING.md](https://github.com/aws/aws-toolkit-vscode/blob/master/CONTRIBUTING.md#guidelines). - License: I confirm that my contribution is made under the terms of the Apache 2.0 license.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
On Windows, if a /doc user changes a folder to a nested subfolder more than one level below the workspace level, the folderPath sent to the API includes backslashes, which results in a
The folder you chose did not contain any source fileserror.Solution
Normalize folderPath before making API request
feature/xbranches will not be squash-merged at release time.