Skip to content

Conversation

@jpinkney-aws
Copy link
Contributor

@jpinkney-aws jpinkney-aws commented Mar 21, 2025

Problem

  • when a test fails we have to manually inspect the logs to understand if it was amazon q or toolkit

Solution

  • separate out amazon q and toolkit test runners

Notes

  • web is not seperated out for now since only amazonq has tests for it apparently
  • I think test macOS (18.x, stable) and test Windows (18.x, stable) need to be removed from required in our github configuration, otherwise they will continue to show up but not do anything

TODO

  • add this for linux codebuilds in a future PR

  • Treat all work as PUBLIC. Private feature/x branches will not be squash-merged at release time.
  • Your code changes must meet the guidelines in CONTRIBUTING.md.
  • License: I confirm that my contribution is made under the terms of the Apache 2.0 license.

@Hweinstock
Copy link
Contributor

Awesome, no more scrolling for ages when a test fails! I am assuming core is included in toolkit tests?

@jpinkney-aws
Copy link
Contributor Author

I am assuming core is included in toolkit tests?

Yeah, the toolkit test runners just run the tests in core

@jpinkney-aws jpinkney-aws marked this pull request as ready for review March 21, 2025 16:00
@jpinkney-aws jpinkney-aws requested a review from a team as a code owner March 21, 2025 16:00
@Hweinstock
Copy link
Contributor

Are you planning to do this for Linux builds as well?

@Hweinstock
Copy link
Contributor

Are those two pending checks in status expected a result of this change? Otherwise, LGTM

@jpinkney-aws
Copy link
Contributor Author

Are those two pending checks in status expected a result of this change? Otherwise, LGTM

Yeah, its just because we have those as required checks in our settings. Once we merge this we can change the required checks to be 18.x, stable, toolkit and 18.x, stable, amazonq

@jpinkney-aws
Copy link
Contributor Author

Are you planning to do this for Linux builds as well?

That's the plan eventually but I don't have the bandwidth right now

@jpinkney-aws jpinkney-aws merged commit d67aa9d into aws:master Mar 25, 2025
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants