Skip to content

Conversation

@leigaol
Copy link
Contributor

@leigaol leigaol commented Mar 21, 2025

Problem

We can select @file and @folder in the Q chat menu. But we should be able to also let user select class, function and these symbols.

Solution

Support @code in the context selection of Q chat.

Screenshot 2025-03-21 at 2 15 34 PM
  • Treat all work as PUBLIC. Private feature/x branches will not be squash-merged at release time.
  • Your code changes must meet the guidelines in CONTRIBUTING.md.
  • License: I confirm that my contribution is made under the terms of the Apache 2.0 license.

@leigaol leigaol requested review from a team as code owners March 21, 2025 21:13
@leigaol leigaol marked this pull request as draft March 21, 2025 21:13
@github-actions
Copy link

  • This pull request modifies code in src/* but no tests were added/updated.
    • Confirm whether tests should be added or ensure the PR description explains why tests are not required.

@leigaol leigaol changed the title Falcon symbol feat(amazonq): Add code symbol support in context selection of Q Chat Mar 21, 2025
Copy link
Contributor

@jpinkney-aws jpinkney-aws left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm excited to use this feature!

@leigaol leigaol marked this pull request as ready for review March 25, 2025 18:15
@leigaol
Copy link
Contributor Author

leigaol commented Mar 25, 2025

This does not require review from Flare team

@jpinkney-aws jpinkney-aws merged commit 011654d into aws:master Mar 25, 2025
29 of 31 checks passed
Hweinstock pushed a commit to Hweinstock/aws-toolkit-vscode that referenced this pull request Mar 26, 2025
…aws#6831)

## Problem
We can select @file and @folder in the Q chat menu. But we should be
able to also let user select class, function and these symbols.

## Solution
Support @code in the context selection of Q chat. 

<img width="742" alt="Screenshot 2025-03-21 at 2 15 34 PM"
src="https://github.com/user-attachments/assets/85f99420-831f-4683-bdfa-7a4cd441cf6a"
/>


---

- Treat all work as PUBLIC. Private `feature/x` branches will not be
squash-merged at release time.
- Your code changes must meet the guidelines in
[CONTRIBUTING.md](https://github.com/aws/aws-toolkit-vscode/blob/master/CONTRIBUTING.md#guidelines).
- License: I confirm that my contribution is made under the terms of the
Apache 2.0 license.
contextCommands.push({
workspaceFolder: context.route[0] || '',
type: context.icon === 'folder' ? 'folder' : 'file',
type: (context.label || '') as ContextCommandItemType,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this broke @prompt

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants