feat(amazonq): handle reference for inline with language server #6837
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
| session.firstCompletionDisplayLatency, | ||
| ], | ||
| } | ||
| ReferenceInlineProvider.instance.setInlineReference( |
Contributor
There was a problem hiding this comment.
I'm not entirely familiar with the flow but is it something like this:
- user gets inline suggestion
- it may have a reference attached
- if it does have a reference then show it as a code lens
- if they click the codelens to add a code reference it adds it in the "Code reference log" panel and opens it up
Is that mostly correct?
Contributor
Author
There was a problem hiding this comment.
yes that is right, and I realized that I missed the logging reference on acceptance piece, just added it. Thanks for catching!
Contributor
|
Also, is this dependent on any flare changes? |
Contributor
Author
No, flare already has references support since beginning |
jpinkney-aws
approved these changes
Mar 25, 2025
Hweinstock
pushed a commit
to Hweinstock/aws-toolkit-vscode
that referenced
this pull request
Mar 26, 2025
…6837) ## Problem missing log references for inline with language server ## Solution add them --- - Treat all work as PUBLIC. Private `feature/x` branches will not be squash-merged at release time. - Your code changes must meet the guidelines in [CONTRIBUTING.md](https://github.com/aws/aws-toolkit-vscode/blob/master/CONTRIBUTING.md#guidelines). - License: I confirm that my contribution is made under the terms of the Apache 2.0 license.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
need to log reference for inline with language server
Solution
feature/xbranches will not be squash-merged at release time.