Skip to content

Conversation

@Vandita2020
Copy link
Contributor

Problem

Adding new pattern for ServerlessLand feature.

Solution

Added pattern for SNS integration with Lambda in python, nodejs, java and dotnet runtime, supporting SAM IaC.


  • Treat all work as PUBLIC. Private feature/x branches will not be squash-merged at release time.
  • Your code changes must meet the guidelines in CONTRIBUTING.md.
  • License: I confirm that my contribution is made under the terms of the Apache 2.0 license.

@Vandita2020 Vandita2020 marked this pull request as ready for review March 24, 2025 22:35
@Vandita2020 Vandita2020 requested a review from a team as a code owner March 24, 2025 22:35
@github-actions
Copy link

  • This pull request modifies code in src/* but no tests were added/updated.
    • Confirm whether tests should be added or ensure the PR description explains why tests are not required.
  • This pull request implements a feat or fix, so it must include a changelog entry (unless the fix is for an unreleased feature). Review the changelog guidelines.
    • Note: beta or "experiment" features that have active users should announce fixes in the changelog.
    • If this is not a feature or fix, use an appropriate type from the title guidelines. For example, telemetry-only changes should use the telemetry type.

@hayemaxi
Copy link
Contributor

Does this need a changelog item?

@Vandita2020
Copy link
Contributor Author

Does this need a changelog item?

I don't think so. We will keep adding the patterns for the ServerlessLand feature. Don't find it necessary to add changelog everytime

@hayemaxi
Copy link
Contributor

hayemaxi commented Mar 25, 2025

Let's add one since it's user facing, unless you already added one in another PR for this release. LGTM after that

@hayemaxi hayemaxi merged commit 24b4571 into aws:master Mar 25, 2025
1 of 7 checks passed
Hweinstock pushed a commit to Hweinstock/aws-toolkit-vscode that referenced this pull request Mar 26, 2025
## Problem
Adding new pattern for ServerlessLand feature. 

## Solution
Added pattern for SNS integration with Lambda in python, nodejs, java
and dotnet runtime, supporting SAM IaC.

---

- Treat all work as PUBLIC. Private `feature/x` branches will not be
squash-merged at release time.
- Your code changes must meet the guidelines in
[CONTRIBUTING.md](https://github.com/aws/aws-toolkit-vscode/blob/master/CONTRIBUTING.md#guidelines).
- License: I confirm that my contribution is made under the terms of the
Apache 2.0 license.

---------

Co-authored-by: Vandita Patidar <[email protected]>
Co-authored-by: Maxim Hayes <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants