feat(chat): Initial Agentic Chat loop Setup #6844

ashishrp-aws · 2025-03-25T00:13:07Z

Problem

Setting up new Q Agentic Chat loop with tool use.

Solution

Initial Agentic Chat loop Setup with tool use

Treat all work as PUBLIC. Private feature/x branches will not be squash-merged at release time.
Your code changes must meet the guidelines in CONTRIBUTING.md.
License: I confirm that my contribution is made under the terms of the Apache 2.0 license.

github-actions · 2025-03-25T00:13:24Z

This pull request modifies code in src/* but no tests were added/updated.
- Confirm whether tests should be added or ensure the PR description explains why tests are not required.
This pull request implements a feat or fix, so it must include a changelog entry (unless the fix is for an unreleased feature). Review the changelog guidelines.
- Note: beta or "experiment" features that have active users should announce fixes in the changelog.
- If this is not a feature or fix, use an appropriate type from the title guidelines. For example, telemetry-only changes should use the telemetry type.

packages/core/src/codewhispererChat/controllers/chat/chatRequest/converter.ts

packages/core/src/codewhispererChat/storages/chatHistory.ts

packages/core/src/shared/utilities/workspaceUtils.ts

packages/core/src/codewhispererChat/controllers/chat/chatRequest/converter.ts

ctlai95 · 2025-03-25T01:00:24Z

packages/core/src/codewhispererChat/controllers/chat/chatRequest/converter.ts

+    [key: string]: any
+}
+
 export function triggerPayloadToChatRequest(triggerPayload: TriggerPayload): { conversationState: ConversationState } {


Can we move the changes to a new function triggerPayloadToAgenticChatRequest

Why do we need a new one? we can use the same function and add the API request blocks based on triggerPayload right?

I see, then should tools also be part of triggerPayload? Because it's not needed for mynah

not needed, but i can make sure that Origin is present to exclude tools from the request. I'll do it in followup

packages/core/src/codewhispererChat/controllers/chat/chatRequest/converter.ts

packages/core/src/codewhispererChat/tools/tool_index.json

packages/core/src/codewhispererChat/controllers/chat/controller.ts

…r comments

packages/core/src/codewhispererChat/storages/chatHistory.ts

packages/core/src/shared/utilities/workspaceUtils.ts

mr-lee · 2025-03-25T00:45:47Z

packages/core/src/codewhispererChat/controllers/chat/chatRequest/converter.ts

    const customizationArn: string | undefined = undefinedIfEmpty(triggerPayload.customization.arn)
    const chatTriggerType = triggerPayload.trigger === ChatTriggerType.InlineChatMessage ? 'INLINE_CHAT' : 'MANUAL'

+    const tools: Tool[] = Object.entries(toolsJson as Record<string, ToolSpec>).map(([toolName, toolSpec]) => ({


I feel like this won't be easily scalable to other use cases like MCP where arbitrary tools can be added. Is there a better way to do this?

We can have a number of static tools. I have moved this to constants. Agreed will check for a better way to handle tools.

mr-lee · 2025-03-25T02:31:57Z

packages/core/src/codewhispererChat/controllers/chat/controller.ts

+                let result: any
+                const toolResults: ToolResult[] = []
+                try {
+                    switch (toolUse.name) {


did you comment things out here intentionally?

yes....write tools aren't merged yet.

ctlai95 · 2025-03-25T19:13:05Z

packages/core/src/codewhispererChat/constants.ts

+export const tools: Tool[] = Object.entries(toolsJson).map(([, toolSpec]) => ({
+    toolSpecification: {
+        ...toolSpec,
+        inputSchema: { json: toolSpec.inputSchema },


nit: I think we don't need to do this anymore because we changed the tool index from index_schema to indexSchema

ctlai95 · 2025-03-25T19:34:37Z

Synced up offline. Please follow up with:

Format history (remove tools from user input message)
Fix history so that user input message is not the last message before the API call

packages/core/src/codewhispererChat/controllers/chat/controller.ts

Initial Agentic loop Setup

3c8e737

ashishrp-aws requested review from a team as code owners March 25, 2025 00:13

ashishrp-aws closed this Mar 25, 2025

ashishrp-aws reopened this Mar 25, 2025

ashishrp-aws changed the base branch from master to feature/agentic-chat March 25, 2025 00:13

Merge branch 'feature/agentic-chat' into feature/agentic-chat

f0d6050

jguoamz reviewed Mar 25, 2025

View reviewed changes

ctlai95 reviewed Mar 25, 2025

View reviewed changes

packages/core/src/codewhispererChat/controllers/chat/chatRequest/converter.ts Outdated Show resolved Hide resolved

ctlai95 reviewed Mar 25, 2025

View reviewed changes

packages/core/src/codewhispererChat/controllers/chat/chatRequest/converter.ts Show resolved Hide resolved

ctlai95 reviewed Mar 25, 2025

View reviewed changes

packages/core/src/codewhispererChat/controllers/chat/chatRequest/converter.ts Outdated Show resolved Hide resolved

ctlai95 reviewed Mar 25, 2025

View reviewed changes

packages/core/src/codewhispererChat/tools/tool_index.json Outdated Show resolved Hide resolved

ctlai95 reviewed Mar 25, 2025

View reviewed changes

packages/core/src/codewhispererChat/controllers/chat/controller.ts Show resolved Hide resolved

Removing Environment state objects from converter and addressing othe…

b4b7a3d

…r comments

ctlai95 reviewed Mar 25, 2025

View reviewed changes

packages/core/src/codewhispererChat/storages/chatHistory.ts Outdated Show resolved Hide resolved

ctlai95 reviewed Mar 25, 2025

View reviewed changes

packages/core/src/shared/utilities/workspaceUtils.ts Outdated Show resolved Hide resolved

mr-lee reviewed Mar 25, 2025

View reviewed changes

Removed merge conflicts

545870e

laileni-aws requested a review from mr-lee March 25, 2025 18:05

jpinkney-aws approved these changes Mar 25, 2025

View reviewed changes

laileni-aws approved these changes Mar 25, 2025

View reviewed changes

ctlai95 reviewed Mar 25, 2025

View reviewed changes

ctlai95 approved these changes Mar 25, 2025

View reviewed changes

ctlai95 reviewed Mar 25, 2025

View reviewed changes

packages/core/src/codewhispererChat/controllers/chat/controller.ts Show resolved Hide resolved

jpinkney-aws merged commit 2dbe485 into aws:feature/agentic-chat Mar 25, 2025
16 of 17 checks passed

ashishrp-aws deleted the feature/agentic-chat branch March 25, 2025 20:39

feat(chat): Initial Agentic Chat loop Setup #6844

feat(chat): Initial Agentic Chat loop Setup #6844

Uh oh!

Conversation

ashishrp-aws commented Mar 25, 2025

Problem

Solution

Uh oh!

github-actions bot commented Mar 25, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ctlai95 Mar 25, 2025

Choose a reason for hiding this comment

Uh oh!

ashishrp-aws Mar 25, 2025

Choose a reason for hiding this comment

Uh oh!

ctlai95 Mar 25, 2025

Choose a reason for hiding this comment

Uh oh!

ashishrp-aws Mar 25, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

mr-lee Mar 25, 2025

Choose a reason for hiding this comment

Uh oh!

ashishrp-aws Mar 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mr-lee Mar 25, 2025

Choose a reason for hiding this comment

Uh oh!

ashishrp-aws Mar 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ctlai95 Mar 25, 2025

Choose a reason for hiding this comment

Uh oh!

ctlai95 commented Mar 25, 2025

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

ashishrp-aws Mar 25, 2025 •

edited

Loading

ashishrp-aws Mar 25, 2025 •

edited

Loading