fix(ziputil): ensure codeDiff is generated when there are uncommitted changes #6855
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
codeDifffolder was missing from zip output.Solution
Verify
The following test case now passes when there are uncommitted changes to the repo.
I did not commit this test case because it fails when there are aren't uncommitted changes. Currently this is difficult to test due to the nature of the code. This partly addressed in the same PR above.
Future Work
Rework/refactor the gitdiff logic to be more testable.
feature/xbranches will not be squash-merged at release time.