feat(chat): Adding execute bash tool setup in Q Agentic chat loop #6856
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
mr-lee
reviewed
Mar 26, 2025
| const lines = result.output.content.split('\n') | ||
| const hasFileA = lines.some((line) => line.includes('- ') && line.includes('fileA.txt')) | ||
| const hasSubfolder = lines.some((line) => line.includes('d ') && line.includes('subfolder')) | ||
| const hasFileA = lines.some((line: string | string[]) => line.includes('- ') && line.includes('fileA.txt')) |
There was a problem hiding this comment.
Wait, why did you need to change the type here?
Contributor
Author
There was a problem hiding this comment.
once i updated output type in tool shared file to accomodate to json type output...this threw failures.
mr-lee
reviewed
Mar 26, 2025
| } | ||
| } catch (error) { | ||
| // Log the error but don't let it crash the process | ||
| throw new Error('Error handling output chunk') |
There was a problem hiding this comment.
For debugging you might want to log the chunk
Contributor
Author
There was a problem hiding this comment.
Will add in followup
mr-lee
approved these changes
Mar 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Execute bash tool is added but is not hooked to the Q Agentic chat yet.
Solution
Adding execute bash tool setup in Q Agentic chat loop.
feature/xbranches will not be squash-merged at release time.