telemetry(amazonq): Add id2 and logging for createUpload metrics #6857
+25
−11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
zuoyaofu
changed the title
laileni-aws
approved these changes
Mar 27, 2025
ashishrp-aws
approved these changes
Mar 27, 2025
ctlai95
approved these changes
Mar 27, 2025
justinmk3
reviewed
Mar 27, 2025
|
|
||
| try { | ||
| const response = await request.fetch('PUT', resp.uploadUrl, { | ||
| body: readFileSync(fileName), |
Contributor
There was a problem hiding this comment.
Is it possible this exceeds a request size limit? Should it be streamed?
justinmk3
reviewed
Mar 27, 2025
| logger.debug(`StatusCode: ${response.status}, Text: ${response.statusText}`) | ||
| requestId = response.headers?.get('x-amz-request-id') ?? undefined | ||
| id2 = response.headers?.get('x-amz-id-2') ?? undefined | ||
| responseCode = response.status.toString() |
Contributor
There was a problem hiding this comment.
Not great that all of this is placed in the business logic for a feature. This kind of thing should live in shared/request. It is generally useful for many features.
And clearly, it's not easy to get right, since this PR is already fixing a bug related to it. Yet this bug fix won't be shared with other similar code that needs to make requests (even if it's specific to S3 PUT).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Some users are reporting S3 upload failures but we don't have the id2 that S3 team requires to investigate further.
Related Commons change: #1005
Solution
Emit amazonq_createUpload metric with id2, and add logs for these ids so customers can use too.
feature/xbranches will not be squash-merged at release time.