Skip to content

Conversation

@ctlai95
Copy link
Contributor

@ctlai95 ctlai95 commented Mar 27, 2025

Problem

ChatStream should be able to send messages for more use cases than just bash output.

Solution

Reuse the chat stream class for all tool messages


  • Treat all work as PUBLIC. Private feature/x branches will not be squash-merged at release time.
  • Your code changes must meet the guidelines in CONTRIBUTING.md.
  • License: I confirm that my contribution is made under the terms of the Apache 2.0 license.

@github-actions
Copy link

  • This pull request modifies code in src/* but no tests were added/updated.
    • Confirm whether tests should be added or ensure the PR description explains why tests are not required.
  • This pull request implements a feat or fix, so it must include a changelog entry (unless the fix is for an unreleased feature). Review the changelog guidelines.
    • Note: beta or "experiment" features that have active users should announce fixes in the changelog.
    • If this is not a feature or fix, use an appropriate type from the title guidelines. For example, telemetry-only changes should use the telemetry type.

@ctlai95 ctlai95 marked this pull request as ready for review March 27, 2025 21:24
@ctlai95 ctlai95 requested a review from a team as a code owner March 27, 2025 21:24
messageID: toolUseId ?? `tool-output`,
userIntent: undefined,
codeBlockLanguage: 'plaintext',
codeBlockLanguage: undefined,
Copy link
Contributor

@ashishrp-aws ashishrp-aws Mar 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: why is it undefined here for tool logs?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was thinking it should be generic, not always plaintext

@mr-lee mr-lee merged commit 7ece541 into aws:feature/agentic-chat Mar 27, 2025
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants