-
Notifications
You must be signed in to change notification settings - Fork 749
feat(stepfunctions): use readonly mode of workflowStudio to render StateMachine in CDK Applications #6874
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
jpinkney-aws
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for that video it was super useful! Is there any videos/documentation on what feature is getting removed here?
packages/core/src/stepFunctions/workflowStudio/handleMessage.ts
Outdated
Show resolved
Hide resolved
packages/core/src/stepFunctions/commands/visualizeStateMachine/aslVisualization.ts
Show resolved
Hide resolved
We are replacing the legacy CDK render graph webview with the readonly WFS. I don't believe there's anything right now in the MarketPlace documentation that mentions the render CDK graph feature. However I can update the MarketPlace documentation to highlight the change we did. The last update is to highlight WorkflowStudio in Toolkit 3b1d258. |
packages/core/src/stepFunctions/commands/visualizeStateMachine/renderStateMachineGraphCDK.ts
Outdated
Show resolved
Hide resolved
packages/toolkit/.changes/next-release/Feature-bd80ac3c-3d3c-45c3-aa6a-16231a63c43d.json
Outdated
Show resolved
Hide resolved
justinmk3
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for cleaning up the old/unused code. That is very helpful and valuable.
…ateMachine in CDK Applications

Problem
As we added support for WorkflowStudio in Toolkit for editing ASL language files, we want to upgrade the render StateMachine Graph in CDK applications experience with the a readonly mode of WorkflowStudio which has better visualization, a code pane for view ASL definition, an export mechanism for exporting ASL definition in JSON/YAML or PNG/SVG.
Solution
Removed the old visualization classes that links to the legacy renderer CDN. From the
renderStateMachineGraphCDKwizard, upon finding thetemplate.jsonfile for a specific stateMachine, we send the file uri to WorkflowStudioEditorProvider to open a readonly WFS to render the StateMachine Graph.feature/xbranches will not be squash-merged at release time.