Skip to content

Conversation

@ctlai95
Copy link
Contributor

@ctlai95 ctlai95 commented Mar 29, 2025

Problem

FsRead doesn't show readRange so there can be duplicate messages when a file is read in chunks.

Solution

Stream the readRange info to the chat.
Assumes the changes in #6888 will be merged so that fsRead will not support reading directories anymore.


  • Treat all work as PUBLIC. Private feature/x branches will not be squash-merged at release time.
  • Your code changes must meet the guidelines in CONTRIBUTING.md.
  • License: I confirm that my contribution is made under the terms of the Apache 2.0 license.

@github-actions
Copy link

  • This pull request modifies code in src/* but no tests were added/updated.
    • Confirm whether tests should be added or ensure the PR description explains why tests are not required.
  • This pull request implements a feat or fix, so it must include a changelog entry (unless the fix is for an unreleased feature). Review the changelog guidelines.
    • Note: beta or "experiment" features that have active users should announce fixes in the changelog.
    • If this is not a feature or fix, use an appropriate type from the title guidelines. For example, telemetry-only changes should use the telemetry type.

@ctlai95 ctlai95 marked this pull request as ready for review March 29, 2025 01:56
@ctlai95 ctlai95 requested a review from a team as a code owner March 29, 2025 01:56
const [start, end] = this.readRange ?? []

if (start && end) {
updates.write(`from line ${start} to ${end}`)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

don't forget i18n

@mr-lee mr-lee merged commit b910472 into aws:feature/agentic-chat Mar 29, 2025
22 checks passed
if (start > 0) {
updates.write(`from line ${start} to end of file`)
} else {
updates.write(`${start} line from the end of file to end of file`)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants