-
Notifications
You must be signed in to change notification settings - Fork 749
feat(chat): Add warning UI for high risk bash command #6895
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
zixlin7
merged 1 commit into
aws:feature/agentic-chat
from
tsmithsz:feature/agentic-chat
Apr 1, 2025
Merged
feat(chat): Add warning UI for high risk bash command #6895
zixlin7
merged 1 commit into
aws:feature/agentic-chat
from
tsmithsz:feature/agentic-chat
Apr 1, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
jguoamz
reviewed
Mar 31, 2025
f7031f2 to
5c42da0
Compare
zixlin7
reviewed
Apr 1, 2025
5c42da0 to
1ba7461
Compare
jpinkney-aws
reviewed
Apr 1, 2025
justinmk3
approved these changes
Apr 1, 2025
Contributor
justinmk3
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I created https://taskei.amazon.dev/tasks/IDE-16429 to track dependencies such as shlex which we can remove after migrating to Flare.
1ba7461 to
6facffb
Compare
zixlin7
reviewed
Apr 1, 2025
6facffb to
621e623
Compare
zixlin7
approved these changes
Apr 1, 2025
621e623 to
49380c6
Compare
jpinkney-aws
approved these changes
Apr 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
AppSec has required that we give the user an indication if they are about to run a potentially dangerous command
Solution
Tests
feature/xbranches will not be squash-merged at release time.