Skip to content

Conversation

@tsmithsz
Copy link
Contributor

@tsmithsz tsmithsz commented Mar 31, 2025

Problem

AppSec has required that we give the user an indication if they are about to run a potentially dangerous command

Solution

  • Parse bash command to determine whether or not commands are dangerous or not.
  • Display message warning to user

Tests

Screenshot 2025-03-31 at 1 03 14 PM


  • Treat all work as PUBLIC. Private feature/x branches will not be squash-merged at release time.
  • Your code changes must meet the guidelines in CONTRIBUTING.md.
  • License: I confirm that my contribution is made under the terms of the Apache 2.0 license.

@tsmithsz tsmithsz requested review from a team as code owners March 31, 2025 23:38
@github-actions
Copy link

  • This pull request implements a feat or fix, so it must include a changelog entry (unless the fix is for an unreleased feature). Review the changelog guidelines.
    • Note: beta or "experiment" features that have active users should announce fixes in the changelog.
    • If this is not a feature or fix, use an appropriate type from the title guidelines. For example, telemetry-only changes should use the telemetry type.

@tsmithsz tsmithsz force-pushed the feature/agentic-chat branch from f7031f2 to 5c42da0 Compare April 1, 2025 00:11
@tsmithsz tsmithsz force-pushed the feature/agentic-chat branch from 5c42da0 to 1ba7461 Compare April 1, 2025 02:38
Copy link
Contributor

@justinmk3 justinmk3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I created https://taskei.amazon.dev/tasks/IDE-16429 to track dependencies such as shlex which we can remove after migrating to Flare.

@tsmithsz tsmithsz force-pushed the feature/agentic-chat branch from 1ba7461 to 6facffb Compare April 1, 2025 19:25
@tsmithsz tsmithsz force-pushed the feature/agentic-chat branch from 6facffb to 621e623 Compare April 1, 2025 19:47
@tsmithsz tsmithsz force-pushed the feature/agentic-chat branch from 621e623 to 49380c6 Compare April 1, 2025 19:55
@zixlin7 zixlin7 merged commit 7a47e33 into aws:feature/agentic-chat Apr 1, 2025
20 of 22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants