(fix)chat: fix the bash output is not formatted #6907
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
laileni-aws
approved these changes
Apr 1, 2025
tsmithsz
approved these changes
Apr 1, 2025
zixlin7
reviewed
Apr 1, 2025
| const stderrBuffer: string[] = [] | ||
|
|
||
| let firstChunk = true | ||
| let firstStderrChunk = true |
Contributor
There was a problem hiding this comment.
what is this flag used for?
Contributor
There was a problem hiding this comment.
If it's the first chunk we append this mark down string ('```console\n') before the text to format the code block appropriately
zixlin7
approved these changes
Apr 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
When the excutable command fails, the output is not formatted.
Solution
Format the stderr the same as stdout.
feature/xbranches will not be squash-merged at release time.