Skip to content

Conversation

@tsmithsz
Copy link
Contributor

@tsmithsz tsmithsz commented Apr 1, 2025

Problem

Regular read-only commands are being categorized as high risk.

Solution

  • Split commands by additional operators
  • Do not automatically default to return false on readOnly command

Testing

  • Tested manually via plugin build
  • Updated unit tests
Screenshot 2025-04-01 at 3 50 48 PM ---
  • Treat all work as PUBLIC. Private feature/x branches will not be squash-merged at release time.
  • Your code changes must meet the guidelines in CONTRIBUTING.md.
  • License: I confirm that my contribution is made under the terms of the Apache 2.0 license.

@tsmithsz tsmithsz requested a review from a team as a code owner April 1, 2025 22:36
@github-actions
Copy link

github-actions bot commented Apr 1, 2025

  • This pull request modifies code in src/* but no tests were added/updated.
    • Confirm whether tests should be added or ensure the PR description explains why tests are not required.
  • This pull request implements a feat or fix, so it must include a changelog entry (unless the fix is for an unreleased feature). Review the changelog guidelines.
    • Note: beta or "experiment" features that have active users should announce fixes in the changelog.
    • If this is not a feature or fix, use an appropriate type from the title guidelines. For example, telemetry-only changes should use the telemetry type.

@ammathu
Copy link

ammathu commented Apr 1, 2025

Can you add testing details. I.e how did you very this?

@tsmithsz tsmithsz force-pushed the feature/agentic-chat branch from 6e7f850 to 5456f67 Compare April 1, 2025 22:51
@tsmithsz tsmithsz requested a review from a team as a code owner April 1, 2025 22:51
@tsmithsz
Copy link
Contributor Author

tsmithsz commented Apr 1, 2025

Can you add testing details. I.e how did you very this?
Added to the description above

@tsmithsz tsmithsz marked this pull request as draft April 1, 2025 23:08
@tsmithsz tsmithsz force-pushed the feature/agentic-chat branch 2 times, most recently from a10bd65 to 232d74a Compare April 1, 2025 23:25
@tsmithsz tsmithsz marked this pull request as ready for review April 1, 2025 23:27
@tsmithsz tsmithsz force-pushed the feature/agentic-chat branch from 232d74a to ce66d96 Compare April 1, 2025 23:53
@zixlin7 zixlin7 merged commit 462df07 into aws:feature/agentic-chat Apr 2, 2025
19 of 22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants