feat(chat): Add validation to fileRead, ListDir and ExecBash tool #6987
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
bywang56
force-pushed
the
feature/agentic-chat
branch
from
36a61be to
77c02ac
Compare
bywang56
force-pushed
the
feature/agentic-chat
branch
from
77c02ac to
c7ddadd
Compare
justinmk3
reviewed
Apr 10, 2025
Comment on lines
+459
to
+462
| "AWS.amazonq.fsRead.run": "Run", | ||
| "AWS.amazonq.fsRead.reject": "Reject", | ||
| "AWS.amazonq.listDirectory.run": "Run", | ||
| "AWS.amazonq.listDirectory.reject": "Reject", |
Contributor
There was a problem hiding this comment.
nls.json is only necessary if these strings are used in package.json
and for common strings, update packages/core/src/shared/localizedText.ts, don't repeat them with different ids. Why would "fsRead" and "listDirectory" have different words for "Run"? Avoid over-abstracting, that is even more costly than not abstracting at all.
justinmk3
reviewed
Apr 10, 2025
Comment on lines
+197
to
+199
| for (const cmdArgs of allCommands) { | ||
| for (const arg of cmdArgs) { | ||
| if (this.looksLikePath(arg)) { |
Contributor
There was a problem hiding this comment.
what is going on here? you have coded a double loop without a comment giving a hint about what it does.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
We should ask for consensus tools accessing files/dirs outside of workspace
Solution
Add validation step when accessing files/dirs outside of workspace using fsRead or listDirectories tools.
Tests
Tests tools, verified button shows up and workflow continues to finish after "accept".
feature/xbranches will not be squash-merged at release time.