Skip to content

Conversation

@ashishrp-aws
Copy link
Contributor

@ashishrp-aws ashishrp-aws commented Apr 10, 2025

Problem

Currently stop button and new prompt only stop with UI changes but agentic loop continues on the background and new messages keep streaming in.

Solution

  • Correcting the setup for the agentic loop.
  • This stops the agentic loop completely with multiple checks.
  • Trigger Id for each new user prompt linked to a token to track an agentic loop Conversation.
  • Added multiple cancellation checks to stop the loop once we hit the stop condition.
  • Stops the Execute Bash executions once stop is clicked

  • Treat all work as PUBLIC. Private feature/x branches will not be squash-merged at release time.
  • Your code changes must meet the guidelines in CONTRIBUTING.md.
  • License: I confirm that my contribution is made under the terms of the Apache 2.0 license.

@ashishrp-aws ashishrp-aws requested review from a team as code owners April 10, 2025 02:42
@github-actions
Copy link

  • This pull request modifies code in src/* but no tests were added/updated.
    • Confirm whether tests should be added or ensure the PR description explains why tests are not required.

@ashishrp-aws ashishrp-aws changed the title Feature/agentic chat feat(chat): agentic chat loop stop with teigger ID tarcking for conversation Apr 10, 2025
@ashishrp-aws ashishrp-aws reopened this Apr 10, 2025
@github-actions
Copy link

  • This pull request modifies code in src/* but no tests were added/updated.
    • Confirm whether tests should be added or ensure the PR description explains why tests are not required.
  • This pull request implements a feat or fix, so it must include a changelog entry (unless the fix is for an unreleased feature). Review the changelog guidelines.
    • Note: beta or "experiment" features that have active users should announce fixes in the changelog.
    • If this is not a feature or fix, use an appropriate type from the title guidelines. For example, telemetry-only changes should use the telemetry type.

@ashishrp-aws ashishrp-aws changed the title feat(chat): agentic chat loop stop with teigger ID tarcking for conversation feat(chat): agentic chat loop stop with trigger ID for tracking conversation Apr 10, 2025
@ashishrp-aws
Copy link
Contributor Author

/retryBuilds

@justinmk3 justinmk3 merged commit 04f3bf9 into aws:feature/agentic-chat Apr 11, 2025
22 checks passed
@ashishrp-aws ashishrp-aws deleted the feature/agentic-chat branch April 11, 2025 23:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants