Skip to content

Conversation

@bywang56
Copy link
Contributor

Problem

We should ask for consensus tools accessing files/dirs outside of workspace

Solution

Add validation step when accessing files/dirs outside of workspace using fsRead or listDirectories tools.


  • Treat all work as PUBLIC. Private feature/x branches will not be squash-merged at release time.
  • Your code changes must meet the guidelines in CONTRIBUTING.md.
  • License: I confirm that my contribution is made under the terms of the Apache 2.0 license.

@bywang56 bywang56 requested review from a team as code owners April 10, 2025 22:19
@github-actions
Copy link

  • This pull request implements a feat or fix, so it must include a changelog entry (unless the fix is for an unreleased feature). Review the changelog guidelines.
    • Note: beta or "experiment" features that have active users should announce fixes in the changelog.
    • If this is not a feature or fix, use an appropriate type from the title guidelines. For example, telemetry-only changes should use the telemetry type.

updates.end()
}

public requiresAcceptance(): CommandValidation {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks very similar to this, can we dedupe?

@bywang56 bywang56 force-pushed the feature/consensus branch from a32d7ea to 620c26f Compare April 10, 2025 23:38
@zixlin7 zixlin7 merged commit 4e0659c into aws:feature/agentic-chat Apr 10, 2025
7 checks passed
break
case 'reject-tool-use':
answer.header = {
icon: 'shell' as MynahIconsType,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't need icon here right ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants