Skip to content

Conversation

@jguoamz
Copy link
Contributor

@jguoamz jguoamz commented Apr 11, 2025

Problem

  • Reading a big file will use too many tokens and cause a bad UX
  • fsRead will read very slow if the file is big by reading every 100 lines

Solution

  • Truncating the output of fsRead if it's bigger than 200K characters
  • Update fsRead toolSpec
  • Set different output limit for tools as each tool is expected to handle different information and there is a trade-off on tokens vs good UX
  • Improve JSON parse error handling
  • Update toolResult status correctly for failed bash command

  • Treat all work as PUBLIC. Private feature/x branches will not be squash-merged at release time.
  • Your code changes must meet the guidelines in CONTRIBUTING.md.
  • License: I confirm that my contribution is made under the terms of the Apache 2.0 license.

@github-actions
Copy link

  • This pull request implements a feat or fix, so it must include a changelog entry (unless the fix is for an unreleased feature). Review the changelog guidelines.
    • Note: beta or "experiment" features that have active users should announce fixes in the changelog.
    • If this is not a feature or fix, use an appropriate type from the title guidelines. For example, telemetry-only changes should use the telemetry type.

@jguoamz jguoamz force-pushed the fsReadFix branch 6 times, most recently from 8111ec5 to 6d192ea Compare April 11, 2025 19:09
@jguoamz jguoamz changed the title fix(chat): Update FsRead toolspec, set different output limit for tools fix(chat): Update FsRead toolspec, return truncated output is file is too large Apr 11, 2025
@jguoamz jguoamz force-pushed the fsReadFix branch 2 times, most recently from 82d1795 to f7f7c90 Compare April 11, 2025 19:24
@jguoamz jguoamz marked this pull request as ready for review April 11, 2025 19:37
@jguoamz jguoamz requested review from a team as code owners April 11, 2025 19:37
@ashishrp-aws
Copy link
Contributor

/retryBuilds

@mr-lee mr-lee enabled auto-merge April 11, 2025 23:02
@mr-lee mr-lee merged commit 08c7828 into aws:feature/agentic-chat Apr 11, 2025
2 checks passed
@jguoamz jguoamz deleted the fsReadFix branch April 16, 2025 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants