Skip to content

Conversation

@Will-ShaoHua
Copy link
Contributor

@Will-ShaoHua Will-ShaoHua commented Apr 11, 2025

Problem

The CreateUploadUrl and StartTestGenerationJob requests succeeded with the profile ARN attached. However, the ExportResultArchive requests were made without this profile ARN, leading to inconsistent profile resolution between operations.

Solution


  • Treat all work as PUBLIC. Private feature/x branches will not be squash-merged at release time.
  • Your code changes must meet the guidelines in CONTRIBUTING.md.
  • License: I confirm that my contribution is made under the terms of the Apache 2.0 license.

@Will-ShaoHua Will-ShaoHua requested review from a team as code owners April 11, 2025 20:56
@github-actions
Copy link

  • This pull request implements a feat or fix, so it must include a changelog entry (unless the fix is for an unreleased feature). Review the changelog guidelines.
    • Note: beta or "experiment" features that have active users should announce fixes in the changelog.
    • If this is not a feature or fix, use an appropriate type from the title guidelines. For example, telemetry-only changes should use the telemetry type.

Copy link
Contributor

@justinmk3 justinmk3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changelog ?

@Will-ShaoHua
Copy link
Contributor Author

changelog ?

oh i forgot to push

@Will-ShaoHua
Copy link
Contributor Author

fyi @justinmk3 this pr is not ready yet

@Will-ShaoHua
Copy link
Contributor Author

i am querying service logs to find out what else we missed

Copy link
Contributor

@neilk-aws neilk-aws left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this also be changed for the FeatureDev client implementation?

public async exportResultArchive(conversationId: string) {

@Will-ShaoHua
Copy link
Contributor Author

Should this also be changed for the FeatureDev client implementation?

yes

@Will-ShaoHua Will-ShaoHua requested a review from a team as a code owner April 11, 2025 22:51
@Will-ShaoHua
Copy link
Contributor Author

@neilk-aws as your request, funtionally tested / dev
image

@Will-ShaoHua Will-ShaoHua requested a review from neilk-aws April 11, 2025 23:14
@Will-ShaoHua
Copy link
Contributor Author

/ test

image

@Will-ShaoHua
Copy link
Contributor Author

/ review

image

@Will-ShaoHua Will-ShaoHua requested a review from dhasani23 April 11, 2025 23:31
@Will-ShaoHua Will-ShaoHua merged commit 5824582 into aws:master Apr 11, 2025
29 of 31 checks passed
@Will-ShaoHua Will-ShaoHua deleted the profile branch April 11, 2025 23:45
@Will-ShaoHua
Copy link
Contributor Author

thank you all

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants