Skip to content

Conversation

@ashishrp-aws
Copy link
Contributor

Problem

Currently the spinner text on waiting for LLM responses displays Generating your Answer which is not reflective of new features.

Solution

  • Updated it to Thinking

  • Treat all work as PUBLIC. Private feature/x branches will not be squash-merged at release time.
  • Your code changes must meet the guidelines in CONTRIBUTING.md.
  • License: I confirm that my contribution is made under the terms of the Apache 2.0 license.

@ashishrp-aws ashishrp-aws requested a review from a team as a code owner April 15, 2025 00:20
@github-actions
Copy link

  • This pull request modifies code in src/* but no tests were added/updated.
    • Confirm whether tests should be added or ensure the PR description explains why tests are not required.
  • This pull request implements a feat or fix, so it must include a changelog entry (unless the fix is for an unreleased feature). Review the changelog guidelines.
    • Note: beta or "experiment" features that have active users should announce fixes in the changelog.
    • If this is not a feature or fix, use an appropriate type from the title guidelines. For example, telemetry-only changes should use the telemetry type.

@mr-lee mr-lee merged commit 7817f35 into aws:feature/agentic-chat Apr 15, 2025
16 of 22 checks passed
copyToClipboard: 'Copied to clipboard',
noMoreTabsTooltip: 'You can only open ten conversation tabs at a time.',
codeSuggestionWithReferenceTitle: 'Some suggestions contain code with references.',
spinnerText: 'Generating your answer...',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this will impact /dev, /test, etc? Can we make a new one for cwc only?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes it will...UIComponentText based on tab config (which available i would have set it to only for cwc and pair programmer mode)

noMoreTabsTooltip: 'You can only open ten conversation tabs at a time.',
codeSuggestionWithReferenceTitle: 'Some suggestions contain code with references.',
spinnerText: 'Generating your answer...',
spinnerText: 'Thinking...',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess this will be impacting entire Amazon Q including /dev etc
Are we ok for this ?
If Yes we are good!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ashishrp-aws ashishrp-aws deleted the feature/agentic-chat branch April 15, 2025 07:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants