-
Notifications
You must be signed in to change notification settings - Fork 747
feat(core): Update all references to use new auth class using flare identity server for Amazon Q #7088
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
opieter-aws
merged 16 commits into
aws:feature/amazonqLSP-auth
from
opieter-aws:feature/amazonqLSP-auth
Apr 21, 2025
Merged
feat(core): Update all references to use new auth class using flare identity server for Amazon Q #7088
opieter-aws
merged 16 commits into
aws:feature/amazonqLSP-auth
from
opieter-aws:feature/amazonqLSP-auth
Apr 21, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Justin M. Keyes <[email protected]>
…feature/amazonqLSP-auth
…dentity server for Amazon Q
|
hayemaxi
reviewed
Apr 21, 2025
hayemaxi
approved these changes
Apr 21, 2025
e08eb59
into
aws:feature/amazonqLSP-auth
11 of 22 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The business logic of auth-related features is complex and implemented separately for all IDEs. Flare/DEXP LSP server has implemented auth that can be reused for all IDEs. The source code was introduced already introduced in #6958 with activation and client updates in #7062. But the references to
AuthUtilthrough the codebase weren't updated yet.Solution
AuthUtilin the codebasetoolkitsunit tests are passingamazonqandwebunit tests still failing, to be addressed in follow-up PRNote that CI is expected to fail for amazonq and web unit tests
feature/xbranches will not be squash-merged at release time.