feat(core): add value length cap to partialClone #7150
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as resolved.
This comment was marked as resolved.
Hweinstock
changed the title
Hweinstock
force-pushed
the
partialCloneValueCap
branch
from
c57b32d to
c0990b0
Compare
Hweinstock
commented
Apr 23, 2025
| describe('partialClone', function () { | ||
| it('omits properties by depth', function () { | ||
| const testObj = { | ||
| let multipleTypedObj: object |
Contributor
Author
There was a problem hiding this comment.
this is changed to avoid duplicate code lint fail.
| }) | ||
| }) | ||
|
|
||
| it('truncates properties by maxLength', function () { |
Contributor
There was a problem hiding this comment.
We want to also test when there are other non object types like number or boolean
Contributor
Author
There was a problem hiding this comment.
Good callout, I've adjusted the test to avoid only using strings.
nkomonen-amazon
approved these changes
Apr 23, 2025
opieter-aws
approved these changes
Apr 24, 2025
justinmk3
approved these changes
Apr 24, 2025
Hweinstock
force-pushed
the
partialCloneValueCap
branch
from
b0a3ea3 to
c49b272
Compare
Contributor
Author
|
failing test tracked in #7153 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
If we want to log a large json object with giant strings (think whole files), it can make the logs difficult to read. This is especially relevant when the underlying string values are not very important.
Solution
maxStringLengthoption.Notes
I am planning to port this utility to Flare to improve the logging experience there, and want this functionality to exist there however I thought this could be useful here too.
feature/xbranches will not be squash-merged at release time.