feat(amazonq): enable client-side build #7226

dhasani23 · 2025-05-05T16:42:06Z

Problem

Instead of running mvn dependency:copy-dependencies and mvn clean install, we have a JAR that we can execute which will gather all of the project dependencies as well as some important metadata stored in a compilations.json file which our service will use to improve the quality of transformations.

Solution

Remove Maven shell commands; add custom JAR execution.

Treat all work as PUBLIC. Private feature/x branches will not be squash-merged at release time.
Your code changes must meet the guidelines in CONTRIBUTING.md.
License: I confirm that my contribution is made under the terms of the Apache 2.0 license.

dhasani23 · 2025-05-05T16:42:59Z

packages/core/src/amazonqGumby/chat/controller/controller.ts

-                    const javaVersion = validProjects[0].JDKVersion ?? JDKVersion.UNSUPPORTED
-                    telemetryJavaVersion = JDKToTelemetryValue(javaVersion) as CodeTransformJavaSourceVersionsAllowed
-                }
-                telemetry.record({ codeTransformLocalJavaVersion: telemetryJavaVersion })


Lots of useless telemetry, so getting rid of some things and will remove them from the commons package shortly

dhasani23 · 2025-05-05T16:44:44Z

packages/core/src/amazonqGumby/errors.ts

    }
 }

-export class ZipExceedsSizeLimitError extends ToolkitError {


We often allowlist certain customers for ZIP size limits greater than the default of 2GB, so remove this client-side check (which didn't seem to work well anyway) and let our service fail the transformation with a relevant error message if the ZIP is too large.

dhasani23 · 2025-05-05T16:45:50Z

packages/core/src/codewhisperer/commands/startTransformByQ.ts

        status = 'FAILED'
-        // TODO if we encounter error in HIL, do we stop job?
        await finalizeTransformByQ(status)
-        // bubble up error to callee function


caller*

Our HIL (Human-in-the-Loop) feature I believe is effectively obsolete once this PR is merged; will discuss to confirm and then hopefully will be able to delete all of the dead HIL-related code here.

dhasani23 · 2025-05-05T16:46:55Z

packages/core/src/codewhisperer/commands/startTransformByQ.ts


-    if (transformByQState.getTransformationType() !== TransformationType.SQL_CONVERSION) {
-        // the below is only applicable when user is doing a Java 8/11 language upgrade
-        const versionInfo = await getVersionData()


This was executing a shell command at the end of every transformation just to emit telemetry on the user's Maven version, which nobody even looked at.

dhasani23 · 2025-05-05T16:48:45Z

packages/core/src/codewhisperer/models/model.ts

        return this.projectCopyFilePath
    }

-    public getJobFailureMetadata() {


This was used to store request IDs when API calls fail, to show to users in the chat. In practice it's difficult to manage this since it required setJobFailureMetadata() to be executed in several places throughout the codebase, often overwriting previous request IDs, so just remove it entirely since we log the full error trace (which will include the request ID) anyway.

dhasani23 · 2025-05-05T16:48:56Z

packages/core/src/codewhisperer/service/transformByQ/transformApiHandler.ts

 }

 export async function zipCode(
-    { dependenciesFolder, humanInTheLoopFlag, projectPath, zipManifest }: IZipCodeParams,


dhasani23 · 2025-05-05T16:49:46Z

packages/core/src/codewhisperer/service/transformByQ/transformApiHandler.ts

-        // We don't add build-logs.txt file to the manifest if we are
-        // uploading HIL artifacts
-        if (!humanInTheLoopFlag) {
-            zip.addLocalFile(logFilePath)


This log file contained the stdout of mvn dependency:copy-dependencies and mvn clean install. We included it in the upload ZIP for an earlier project which never actually happened; our backend does nothing with this file.

dhasani23 · 2025-05-05T16:51:08Z

packages/core/src/codewhisperer/service/transformByQ/transformMavenHandler.ts

-function installProjectDependencies(dependenciesFolder: FolderInfo, modulePath: string) {
-    telemetry.codeTransform_localBuildProject.run(() => {
-        telemetry.record({ codeTransformSessionId: CodeTransformTelemetryState.instance.getSessionId() })
+function collectDependenciesAndMetadata(dependenciesFolderPath: string, workingDirPath: string) {


This diff is a bit difficult to look at, but basically remove installProjectDependencies which ran mvn clean install, remove copyProjectDependencies which ran mvn dependency:copy-dependencies, and instead just run collectDependenciesAndMetadata which will execute the JAR we have.

dhasani23 · 2025-05-05T16:51:48Z

packages/core/src/codewhisperer/service/transformByQ/transformMavenHandler.ts

    void vscode.window.showInformationMessage(CodeWhispererConstants.buildSucceededNotification)
 }

-export async function getVersionData() {


See earlier comment; no point in running a shell command just to emit a metric that nobody looks at.

packages/core/src/amazonqGumby/chat/controller/messenger/messenger.ts

packages/core/src/test/codewhisperer/commands/transformByQ.test.ts

dhasani23 · 2025-05-20T22:44:36Z

packages/core/src/codewhisperer/service/transformByQ/transformFileHandler.ts

    return {
        hilCapability: jsonValues?.hilType,
        pomFolderName: jsonValues?.pomFolderName,
-        // TODO remove this forced version


HIL-related code will be deleted shortly

dhasani23 · 2025-06-11T21:24:48Z

Make sure diff.patch gets parsed correctly from IDE when doing a custom upgrade via YAML (ex. snakeyaml to 2.2)

Update: working fine

ntarakad-aws · 2025-06-20T17:29:10Z

packages/core/src/codewhisperer/models/constants.ts


 export const invalidCustomVersionsFileMessage =
-    'Your .YAML file is not formatted correctly. Make sure that the .YAML file you upload follows the format of the sample file provided.'
+    "I wasn't able to parse the dependency upgrade file. Check that it's configured properly and try again. For an example of the required dependency upgrade file format, see the [documentation](https://docs.aws.amazon.com/amazonq/latest/qdeveloper-ug/code-transformation.html#dependency-upgrade-file)."


nit: Do apostrophes work here?

Yes because of the double quotes

## Problem Instead of running `mvn dependency:copy-dependencies` and `mvn clean install`, we have a JAR that we can execute which will gather all of the project dependencies as well as some important metadata stored in a `compilations.json` file which our service will use to improve the quality of transformations. ## Solution Remove Maven shell commands; add custom JAR execution. --- - Treat all work as PUBLIC. Private `feature/x` branches will not be squash-merged at release time. - Your code changes must meet the guidelines in [CONTRIBUTING.md](https://github.com/aws/aws-toolkit-vscode/blob/master/CONTRIBUTING.md#guidelines). - License: I confirm that my contribution is made under the terms of the Apache 2.0 license. --------- Co-authored-by: David Hasani <[email protected]>

dhasani23 requested review from a team as code owners May 5, 2025 16:42

dhasani23 marked this pull request as draft May 5, 2025 16:42

dhasani23 commented May 5, 2025

View reviewed changes

dhasani23 commented May 6, 2025

View reviewed changes

packages/core/src/amazonqGumby/chat/controller/messenger/messenger.ts Outdated Show resolved Hide resolved

dhasani23 commented May 6, 2025

View reviewed changes

packages/core/src/test/codewhisperer/commands/transformByQ.test.ts Outdated Show resolved Hide resolved

dhasani23 changed the title ~~feat(amazonq): enable client-side build feature, including local maven JAR execution~~ feat(amazonq): enable client-side build feature + local maven JAR execution May 9, 2025

dhasani23 changed the title ~~feat(amazonq): enable client-side build feature + local maven JAR execution~~ feat(amazonq): enable client-side build / run JAR May 9, 2025

dhasani23 force-pushed the csbM3 branch from d77aa79 to 3cd7289 Compare May 20, 2025 22:41

dhasani23 commented May 20, 2025

View reviewed changes

dhasani23 changed the title ~~feat(amazonq): enable client-side build / run JAR~~ feat(amazonq): enable client-side build Jun 3, 2025

dhasani23 force-pushed the csbM3 branch from 3cd7289 to bb6e1de Compare June 3, 2025 20:45

dhasani23 force-pushed the csbM3 branch from 68c2f16 to e9496aa Compare June 10, 2025 21:25

dhasani23 force-pushed the csbM3 branch 4 times, most recently from 32e3752 to d484af6 Compare June 19, 2025 23:16

David Hasani added 4 commits June 19, 2025 16:20

run maven JAR

b6c1115

fix linter

ae0cf2a

fix test

363b061

fix linter

e8cb40c

David Hasani added 15 commits June 19, 2025 16:20

remove gumby from logs

8c34313

updated JAR

18816e2

update test

4c5a126

test update

b783f71

only yaml

3b1c8ad

add yml

f8f5a51

add check for empty diff

c2abd80

small yaml format change

cb775f3

update JAR

7acbaea

always resume even on empty diff

139e910

poll for ACA properly

6d8cead

exclude .yml from patch

ba5caed

stopJob on failure

b914503

text update

790ae7a

update text

6c7fdfe

dhasani23 force-pushed the csbM3 branch from d484af6 to 6c7fdfe Compare June 20, 2025 02:34

dhasani23 marked this pull request as ready for review June 20, 2025 02:34

David Hasani added 2 commits June 19, 2025 19:41

remove comment

570ec6b

fix test

4f73f2e

ntarakad-aws reviewed Jun 20, 2025

View reviewed changes

ntarakad-aws approved these changes Jun 20, 2025

View reviewed changes

David Hasani added 5 commits June 20, 2025 11:06

update text

f8b4b9f

fix timeout issue

fc6530d

fix Windows path issue

6b97d16

remove IDE capability

04b25e1

quick plan fix

c64e337

Randall-Jiang approved these changes Jun 24, 2025

View reviewed changes

dhasani23 merged commit f1dc9b8 into aws:master Jun 24, 2025
31 checks passed

feat(amazonq): enable client-side build #7226

feat(amazonq): enable client-side build #7226

Uh oh!

Conversation

dhasani23 commented May 5, 2025

Problem

Solution

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

dhasani23 May 5, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

dhasani23 May 5, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

dhasani23 commented Jun 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

dhasani23 May 5, 2025 •

edited

Loading

dhasani23 May 5, 2025 •

edited

Loading

dhasani23 commented Jun 11, 2025 •

edited

Loading