Skip to content

Conversation

@jpinkney-aws
Copy link
Contributor

Problem

  • we're moving to inline via flare

Solution

  • deprecate amazon q inline

Notes

deprecation steps:

  1. removed recommendation handler and recommendation service and all regular dependencies, since those are the bulk of inline suggestions
  2. removed command registrations for onacceptance
  3. removed tests that are no longer relevant to the vscode implementation since they are already in flare
  4. modified the lineAnnotationController and activeStateControllers to comment out any missing imports, since those still need to be there in the new implementation
  5. removed pagination calls, since those are now done through flare
  6. remove keystroke handler, since that's now done by the vscode api
  7. removed old cloud9 compatability code for inline

Future PRs:

  • Refactor lineAnnoationController and activeStateControllers
  • re-implement the aws.amazonq.refreshAnnotation command
  • fix the inline e2e tests, since now they will fully go through flare instead of the recommendation handler
  • fix any unit tests that are now failing
  • updating the status bar when a request is in progress

  • Treat all work as PUBLIC. Private feature/x branches will not be squash-merged at release time.
  • Your code changes must meet the guidelines in CONTRIBUTING.md.
  • License: I confirm that my contribution is made under the terms of the Apache 2.0 license.

@jpinkney-aws jpinkney-aws requested review from a team as code owners May 6, 2025 18:52
Copy link
Contributor

@justinmk3 justinmk3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@jpinkney-aws jpinkney-aws merged commit d57cac5 into aws:feature/flare-inline May 6, 2025
21 of 22 checks passed
jpinkney-aws pushed a commit that referenced this pull request May 6, 2025
## Problem
Flare is marked as codeowners of the following:
```
packages/core/src/codewhispererChat/ @aws/flare
packages/core/src/amazonq/ @aws/flare
```

AFAIK, the flare team hasn't done significant work in these folders, and
does not have bandwidth to review changes here.

- `packages/core/src/codewhispererChat/ ` will be mostly deleted when we
complete the migration to Flare (ex.
[here](#7237)).
- `packages/core/src/amazonq/ ` contains most changes to the amazon q
extension, which seems out of scope for the Flare team.

Having flare as codeowners requires the toolkits team to bypass their
approval on any PRs touching files in these directories. This can lead
to delayed merges and confusion.

## Solution
- remove flare as a code owner. 


---

- Treat all work as PUBLIC. Private `feature/x` branches will not be
squash-merged at release time.
- Your code changes must meet the guidelines in
[CONTRIBUTING.md](https://github.com/aws/aws-toolkit-vscode/blob/master/CONTRIBUTING.md#guidelines).
- License: I confirm that my contribution is made under the terms of the
Apache 2.0 license.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants