refactor(amazonq): pull out all decryption logic to one place #7248
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hweinstock
commented
May 7, 2025
| ) | ||
| } else { | ||
| lastPartialResult = partialResult as ChatResult | ||
| const chatDisposable = languageClient.onProgress(chatRequestType, partialResultToken, (partialResult) => |
Contributor
Author
There was a problem hiding this comment.
this refactor is to avoid decrypting partial responses twice
Contributor
Author
|
failing tests are known flaky: #7187. Should look into disabling them at the rate they are failing. |
jpinkney-aws
approved these changes
May 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Follow up to #7235 (comment).
Solution
Verification
Used agentic chat with some tools, as well as inline chat and didn't notice a difference. If encryption were broken, I would expect this to fail immediately.
feature/xbranches will not be squash-merged at release time.