Skip to content

Conversation

@Hweinstock
Copy link
Contributor

@Hweinstock Hweinstock commented May 7, 2025

Problem

These errors show up in telemetry with reason Error. All of the reasonDesc are different since they include unique PID values. This makes it hard to count/quantify how often this is happening.

Solution

  • attach a unique error code to these errors. For when node can't be run we have FailedToRunNode, and when the language server can't be started we have FailedToStartLanguageServer.

  • Treat all work as PUBLIC. Private feature/x branches will not be squash-merged at release time.
  • Your code changes must meet the guidelines in CONTRIBUTING.md.
  • License: I confirm that my contribution is made under the terms of the Apache 2.0 license.

@github-actions
Copy link

github-actions bot commented May 7, 2025

  • This pull request modifies code in src/* but no tests were added/updated.
    • Confirm whether tests should be added or ensure the PR description explains why tests are not required.

@Hweinstock Hweinstock marked this pull request as ready for review May 8, 2025 13:20
@Hweinstock Hweinstock requested a review from a team as a code owner May 8, 2025 13:20
@Hweinstock Hweinstock merged commit 0b169a8 into aws:master May 8, 2025
42 of 46 checks passed
@Hweinstock Hweinstock deleted the addErrorCode branch May 8, 2025 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants