Skip to content

Conversation

@opieter-aws
Copy link
Contributor

@opieter-aws opieter-aws commented May 8, 2025

Problem

There are no unit tests for the new AuthUtil on Flare LSP

Solution

  • Add unit test for core AuthUtil functionality
  • Create a test util for all tests where AuthUtil is needed
  • Ensure all tests that interact with the AuthUtil consume the new test util
  • Add destroy method to the AuthUtil class to simplify cleanup for unit tests

  • Treat all work as PUBLIC. Private feature/x branches will not be squash-merged at release time.
  • Your code changes must meet the guidelines in CONTRIBUTING.md.
  • License: I confirm that my contribution is made under the terms of the Apache 2.0 license.

@opieter-aws opieter-aws marked this pull request as ready for review May 8, 2025 20:13
@opieter-aws opieter-aws requested review from a team as code owners May 8, 2025 20:13
@opieter-aws opieter-aws merged commit 772ea72 into aws:feature/amazonqLSP-auth May 8, 2025
17 of 22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants