Skip to content

Conversation

@Hweinstock
Copy link
Contributor

@Hweinstock Hweinstock commented May 12, 2025

Problem

Adding logging statements to the top level is extremely noisy, since that part still triggers on each key stroke. This could also improve latency since any computation at the top-level will be redone on each keystroke.

Solution

  • move the debounce up a layer.
  • remove outdated tests, since the debounce util already has tests for all this logic.
  • added new tests for new behavior.

Verification

  • I tested this side-by-side with previous version and didn't notice a difference.

  • Treat all work as PUBLIC. Private feature/x branches will not be squash-merged at release time.
  • Your code changes must meet the guidelines in CONTRIBUTING.md.
  • License: I confirm that my contribution is made under the terms of the Apache 2.0 license.

@Hweinstock Hweinstock marked this pull request as ready for review May 12, 2025 22:31
@Hweinstock Hweinstock requested a review from a team as a code owner May 12, 2025 22:31
@Hweinstock Hweinstock requested a review from a team as a code owner May 13, 2025 13:26
@Hweinstock Hweinstock merged commit 2f7c3d9 into aws:feature/flare-inline May 13, 2025
18 of 22 checks passed
@Hweinstock Hweinstock deleted the refactor/debounce-above branch May 13, 2025 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants