Skip to content

Conversation

@nkomonen-amazon
Copy link
Contributor

@nkomonen-amazon nkomonen-amazon commented May 13, 2025

Problem

At the startup of the extension, the customization that a user already decided previously was not being pushed to flare.
The only time we would push the customization to flare was if the customization was changed.

Otherwise everything else works as expected.

Solution

On startup, push the customization to flare (if it already exists)


  • Treat all work as PUBLIC. Private feature/x branches will not be squash-merged at release time.
  • Your code changes must meet the guidelines in CONTRIBUTING.md.
  • License: I confirm that my contribution is made under the terms of the Apache 2.0 license.

@nkomonen-amazon nkomonen-amazon requested a review from a team as a code owner May 13, 2025 20:34
@github-actions
Copy link

  • This pull request modifies code in src/* but no tests were added/updated.
    • Confirm whether tests should be added or ensure the PR description explains why tests are not required.
  • This pull request implements a feat or fix, so it must include a changelog entry (unless the fix is for an unreleased feature). Review the changelog guidelines.
    • Note: beta or "experiment" features that have active users should announce fixes in the changelog.
    • If this is not a feature or fix, use an appropriate type from the title guidelines. For example, telemetry-only changes should use the telemetry type.

@opieter-aws
Copy link
Contributor

Does this not need to go into master?

@nkomonen-amazon nkomonen-amazon changed the base branch from feature/amazonqLSP-auth to master May 13, 2025 22:02
@nkomonen-amazon nkomonen-amazon requested review from a team as code owners May 13, 2025 22:02
At startup of the extension this will explicitly push customizations to the language server

Signed-off-by: nkomonen-amazon <[email protected]>
@nkomonen-amazon nkomonen-amazon merged commit 143e35c into aws:master May 13, 2025
24 of 31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants