-
Notifications
You must be signed in to change notification settings - Fork 748
feat(amazonq): Migrate existing SSO connections to the LSP identity server #7298
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
opieter-aws
merged 8 commits into
aws:feature/amazonqLSP-auth
from
opieter-aws:feature/amazonqLSP-auth
May 14, 2025
Merged
feat(amazonq): Migrate existing SSO connections to the LSP identity server #7298
opieter-aws
merged 8 commits into
aws:feature/amazonqLSP-auth
from
opieter-aws:feature/amazonqLSP-auth
May 14, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
| let profileId: string | undefined | ||
|
|
||
| getLogger().info(`codewhisperer: checking for old SSO connections`) | ||
| if (profiles) { |
Contributor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we return early if !profiles to reduce indentation depth
nkomonen-amazon
approved these changes
May 14, 2025
8f0d76a
into
aws:feature/amazonqLSP-auth
15 of 22 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Existing SSO connections on old auth, are not migrated automatically to the LSP Identity Server. This means that users would be signed out upon migration.
Solution
Add a migration functionality that checks for existing SSO connections, and migrate if necessary:
client.ts, before we attempt to restore any connections in the new authmigrateSsoConnectionToLspmethod toAuthUtil, which:memento, and looks for theauth.profileskeyssoprofile withamazonQScopes. If yes: migrate, if not: nothing to migratefrom) filenames and the Flare (to) filenames for the registration cache file and the SSO token cache fileauth.profileskey to undefined, so migration is skipped next timeTesting
feature/xbranches will not be squash-merged at release time.