fix(amazonq): Customization/Profiles not being sent to LSP on startup #7302
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Problem On start of the extension when we called getSelectedCustomization() it would return the wrong customization. This caused the wrong customization to be pushed to the LSP. The reason was due to notifyNewCustomizations not being called before getSelectedCustomization() was used. Solution Ensure the call that uses notifyNewCustomizations() runs before getSelectedCustomization is used. I also refactored to compartmentalize the relevant code. Signed-off-by: nkomonen-amazon <[email protected]>
This function makes more sense to live in the lsp config folder as it is a general function that pushes a config to the lsp Signed-off-by: nkomonen-amazon <[email protected]>
Because the `AuthUtil.restore()` was called before we registered the onDidChangeRegionProvider, the expected pushConfigUpdate was not called when the server started. This resulted in the cached Developer Profile not being pushed to the LSP. This fixes that. Signed-off-by: nkomonen-amazon <[email protected]>
|
opieter-aws
approved these changes
May 14, 2025
opieter-aws
merged commit f849b3f
into
aws:feature/amazonqLSP-auth
15 of 22 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After some testing there is the edge case of cached Customizations/Profiles not being sent on startup.
This PR fixes that so that they are sent to the LSP on extension startup, when expected.
See each individual commit as they are isolated changes.
feature/xbranches will not be squash-merged at release time.