-
Notifications
You must be signed in to change notification settings - Fork 748
feat(amazonq): show a message when no suggestions are found on manual invoke #7318
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(amazonq): show a message when no suggestions are found on manual invoke #7318
Conversation
|
| } | ||
|
|
||
| if (!session || !items.length || !editor) { | ||
| getLogger().debug( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This log message can help us determine if results not showing are due to vscode quirks or backend issues.
| mockToken | ||
| ) | ||
| // Wait up to a second for message to appear since there is potential race condition. | ||
| await waitUntil(async () => messageShown, { timeout: 1000, interval: 100 }) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
instead of waiting I think you might be able to do something like this:
const p = new Promise((resolve) => {
getTestWindow().onDidShowMessage((e) => {
assert.strictEqual(e.message, noInlineSuggestionsMsg)
resolve()
})
})
and then
await p
here
Co-authored-by: Josh Pinkney <[email protected]>
Problem
When manually invoking inline suggestions, it is possible for the backend to still not reply with results. Since the user took an action to invoke this, we should let them know when it fails.
Solution
Testing and Verification
noSuggestionsDemo.mov
feature/xbranches will not be squash-merged at release time.