Skip to content

Conversation

@leigaol
Copy link
Contributor

@leigaol leigaol commented Jun 16, 2025

Problem

Suggestion state reporting is incorrect.

Solution

  1. When receiving a suggestion, if the cursor is behind invoking position, DISCARD suggestion
  2. When receiving a suggestion, if the cursor is after invoking position and the typeahead does not match DISCARD suggestion.
  3. When user does not do anything with a shown suggestion, we REJECT it the next time we invoke for new suggestions.

  • Treat all work as PUBLIC. Private feature/x branches will not be squash-merged at release time.
  • Your code changes must meet the guidelines in CONTRIBUTING.md.
  • License: I confirm that my contribution is made under the terms of the Apache 2.0 license.

@leigaol leigaol requested a review from a team as a code owner June 16, 2025 23:57
@leigaol leigaol marked this pull request as draft June 16, 2025 23:57
@github-actions
Copy link

  • This pull request modifies code in src/* but no tests were added/updated.
    • Confirm whether tests should be added or ensure the PR description explains why tests are not required.
  • This pull request implements a feat or fix, so it must include a changelog entry (unless the fix is for an unreleased feature). Review the changelog guidelines.
    • Note: beta or "experiment" features that have active users should announce fixes in the changelog.
    • If this is not a feature or fix, use an appropriate type from the title guidelines. For example, telemetry-only changes should use the telemetry type.

@leigaol leigaol marked this pull request as ready for review June 17, 2025 18:36
@leigaol leigaol merged commit 76649f7 into aws:feature/flare-inline Jun 17, 2025
27 of 37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants