Skip to content

Conversation

@leigaol
Copy link
Contributor

@leigaol leigaol commented Jun 17, 2025

Problem

In the inline flare branch, the typeahead experience is bad because even when user typed matching characters after seeing a suggestion, we are still re-fetching the new suggestions, which causes the cached suggestion to disappear and new suggestion re-appear.

Solution

Use the previous suggestion from last invocation if what user typed matches the suggestion prefix.

typeahead.mov

This also aligns the experience in prod plugins without Flare inline.


  • Treat all work as PUBLIC. Private feature/x branches will not be squash-merged at release time.
  • Your code changes must meet the guidelines in CONTRIBUTING.md.
  • License: I confirm that my contribution is made under the terms of the Apache 2.0 license.

@leigaol leigaol requested a review from a team as a code owner June 17, 2025 22:17
@github-actions
Copy link

  • This pull request modifies code in src/* but no tests were added/updated.
    • Confirm whether tests should be added or ensure the PR description explains why tests are not required.
  • This pull request implements a feat or fix, so it must include a changelog entry (unless the fix is for an unreleased feature). Review the changelog guidelines.
    • Note: beta or "experiment" features that have active users should announce fixes in the changelog.
    • If this is not a feature or fix, use an appropriate type from the title guidelines. For example, telemetry-only changes should use the telemetry type.

@leigaol leigaol merged commit 181b5bb into aws:feature/flare-inline Jun 17, 2025
21 of 22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants