-
Notifications
You must be signed in to change notification settings - Fork 746
feat(amazonq): support select images as context #7533
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
|
don't merge unless CI passes |
| canSelectFolders: params.canSelectFolders ?? false, | ||
| canSelectMany: params.canSelectMany ?? false, | ||
| filters: params.filters, | ||
| defaultUri: params.defaultUri ? vscode.Uri.parse(params.defaultUri) : undefined, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what happens if vscode.Uri.parse(params.defaultUri) fails? Do we throw any error to the user or log it ?
laileni-aws
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess we need to have a changeLog for this!
laileni-aws
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Problem
WebView emit event to open system file dialog to use the VSC api to open file dialog, and the event need to be handled by extension
Solution
case OPEN_FILE_DIALOGlanguageClient.onRequest(ShowOpenDialogRequestType.method, async (params: ShowOpenDialogParams)feature/xbranches will not be squash-merged at release time.