Skip to content

Conversation

@yzhangok
Copy link
Contributor

@yzhangok yzhangok commented Jun 20, 2025

Problem

WebView emit event to open system file dialog to use the VSC api to open file dialog, and the event need to be handled by extension

Solution

  1. Register the request between WebView and language server by adding case OPEN_FILE_DIALOG
  2. Add handling for event when language server request to open system file dialog, which is defined in languageClient.onRequest(ShowOpenDialogRequestType.method, async (params: ShowOpenDialogParams)

  • Treat all work as PUBLIC. Private feature/x branches will not be squash-merged at release time.
  • Your code changes must meet the guidelines in CONTRIBUTING.md.
  • License: I confirm that my contribution is made under the terms of the Apache 2.0 license.

@yzhangok yzhangok requested a review from a team as a code owner June 20, 2025 06:53
@github-actions
Copy link

  • This pull request modifies code in src/* but no tests were added/updated.
    • Confirm whether tests should be added or ensure the PR description explains why tests are not required.
  • This pull request implements a feat or fix, so it must include a changelog entry (unless the fix is for an unreleased feature). Review the changelog guidelines.
    • Note: beta or "experiment" features that have active users should announce fixes in the changelog.
    • If this is not a feature or fix, use an appropriate type from the title guidelines. For example, telemetry-only changes should use the telemetry type.

@yzhangok yzhangok changed the title feat(lsp): support select images as context support select images as context Jun 24, 2025
@leigaol
Copy link
Contributor

leigaol commented Jun 25, 2025

don't merge unless CI passes

@yzhangok yzhangok changed the title support select images as context type(feat): support select images as context Jun 26, 2025
@yzhangok yzhangok changed the title type(feat): support select images as context feat(amazonq): support select images as context Jul 9, 2025
canSelectFolders: params.canSelectFolders ?? false,
canSelectMany: params.canSelectMany ?? false,
filters: params.filters,
defaultUri: params.defaultUri ? vscode.Uri.parse(params.defaultUri) : undefined,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what happens if vscode.Uri.parse(params.defaultUri) fails? Do we throw any error to the user or log it ?

Copy link
Contributor

@laileni-aws laileni-aws left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess we need to have a changeLog for this!

Copy link
Contributor

@laileni-aws laileni-aws left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@laileni-aws laileni-aws merged commit c4110ad into aws:master Jul 9, 2025
30 of 31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants