fix(amazonq): remove the depedency of the CDN js script. #7587
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. update the commonAuthViewProvider to use the locally bundled vue.js, instead of to load the vue.js from CDN. 2. this going to resolve the customer request that When customer is trying to login to IDC via Q they are hitting a URL which is not part of the whitelist urls as per [documentation](https://docs.aws.amazon.com/amazonq/latest/qdeveloper-ug/firewall.html)
|
jguoamz
reviewed
Jun 30, 2025
| </head> | ||
| <body> | ||
| <script src="https://cdnjs.cloudflare.com/ajax/libs/vue/3.4.4/vue.global.prod.min.js"></script> | ||
| <script src="${vueScript.toString()}"></script> |
Contributor
There was a problem hiding this comment.
does the version (3.4.4) matter? If the version changes, would it break?
Contributor
Author
There was a problem hiding this comment.
I don't think so, did local tested with the generated vsix for the amazon Q sign in and sign out, didn't see any issue for the login ux with vue.js file in [3.3.4 which is used in the toolkit package](
aws-toolkit-vscode/packages/core/package.json
Line 576 in bfdb0eb
leigaol
approved these changes
Jul 1, 2025
leigaol
reviewed
Jul 1, 2025
|
|
||
| // Vue.js for webviews | ||
| { | ||
| target: path.join('../../node_modules', 'vue', 'dist', 'vue.global.prod.js'), |
Contributor
There was a problem hiding this comment.
please test both Q and toolkit
Contributor
Author
There was a problem hiding this comment.
verified both Q and toolkit can login of the generated vsix. following is the toolkit login, Q login pasted in the pr description
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Customers complain about need to whitelist the
cdnjs.cloudflare.comwhich doesn't listed in the https://docs.aws.amazon.com/amazonq/latest/qdeveloper-ug/firewall.htmlSolution
update the commonAuthViewProvider to use the locally bundled vue.js, instead of to load the vue.js from CDN.
verified the amazon Q auth view still working as expected after this change.
feature/xbranches will not be squash-merged at release time.