feat(sagemaker): Merging Feature/sagemaker connect to staging #7602
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d automatic (aws#2129) ## Problem When the user views SageMaker Studio Spaces in the AWS Toolkit extension, by default it shows all Spaces from the `SageMaker:ListSpaces` API call. We want to show only the Spaces relevant to the user. ## Solution We enable both upfront and manual filtering for the user. Upfront filtering - Filter out Unified Studio Spaces - Filter out Spaces not owned by the user, based on detection of their UserProfileName in the response from `STS:GetCallerIdentity`. We support IAM user, IAM Identity Center user, and STS assumed-role session names. Manual filtering - Allows the user to manually filter out Spaces via a dropdown of checkboxes. --- - Treat all work as PUBLIC. Private `feature/x` branches will not be squash-merged at release time. - Your code changes must meet the guidelines in [CONTRIBUTING.md](https://github.com/aws/aws-toolkit-vscode/blob/master/CONTRIBUTING.md#guidelines). - License: I confirm that my contribution is made under the terms of the Apache 2.0 license. - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - --------- Co-authored-by: Alvin Solidum <[email protected]> Co-authored-by: Newton Der <[email protected]>
## Problem As part of sagemaker-connect project: - User able to connect to sagemaker space from toolkit extension - User able to connect to sagemaker space using deeplink uri ## Solution - Connect using sagemaker startSession API which starts an ssm session - Use remote-ssh extension to handle the ssh connection - Use custom proxy command to handle initial connection and reconnection - Use a detached local endpoint that is able to call startSession to handle connection and reconnection --- - Treat all work as PUBLIC. Private `feature/x` branches will not be squash-merged at release time. - Your code changes must meet the guidelines in [CONTRIBUTING.md](https://github.com/aws/aws-toolkit-vscode/blob/master/CONTRIBUTING.md#guidelines). - License: I confirm that my contribution is made under the terms of the Apache 2.0 license. --------- Co-authored-by: Newton Der <[email protected]> Co-authored-by: Edward Sun <[email protected]>
…#2136) ## Problem - Users should be able to start and stop SageMaker Spaces directly from the Toolkit extension, without relying on the Studio UI. - When actions like start, stop, or connect fail, users currently receive no feedback, making troubleshooting difficult. ## Solution - Added buttons to start and stop a space - Implemented error notifications for failures when viewing, starting, or stopping spaces. - For errors during startSession, display a webpage hosted by the local SageMaker server, since remote VS Code windows cannot display standard error messages from the local server. --- - Treat all work as PUBLIC. Private `feature/x` branches will not be squash-merged at release time. - Your code changes must meet the guidelines in [CONTRIBUTING.md](https://github.com/aws/aws-toolkit-vscode/blob/master/CONTRIBUTING.md#guidelines). - License: I confirm that my contribution is made under the terms of the Apache 2.0 license. --------- Co-authored-by: Newton Der <[email protected]> Co-authored-by: Edward Sun <[email protected]>
## Problem - When the Toolkit connects to a remote space, it should automatically apply the space filter based on the space profile owner. ## Solution 1. Read the metadata file to extract the space name and domain ID. 2. Use the describeSpace API to retrieve the profile name. 3. Apply filtering using the domain ID and profile name as keys. --- - Treat all work as PUBLIC. Private `feature/x` branches will not be squash-merged at release time. - Your code changes must meet the guidelines in [CONTRIBUTING.md](https://github.com/aws/aws-toolkit-vscode/blob/master/CONTRIBUTING.md#guidelines). - License: I confirm that my contribution is made under the terms of the Apache 2.0 license.
Merge staging into feature/sagemaker-connect
…pdate error page styling (aws#2149) ## Problem - Disable deep link reconnect logic for the Phase 1 release of the SageMaker Connect feature, as backend support is not yet ready. Logic will be re-enabled in Phase 2. - Fix styling issues on the error page. ## Solution - Comment out reconnect logic and associated tests. - Return a 200 response with a message for reconnect attempts. --- - Treat all work as PUBLIC. Private `feature/x` branches will not be squash-merged at release time. - Your code changes must meet the guidelines in [CONTRIBUTING.md](https://github.com/aws/aws-toolkit-vscode/blob/master/CONTRIBUTING.md#guidelines). - License: I confirm that my contribution is made under the terms of the Apache 2.0 license.
…ws#7601) - Releasing aws/aws-toolkit-vscode-staging#2144 --- - Treat all work as PUBLIC. Private `feature/x` branches will not be squash-merged at release time. - Your code changes must meet the guidelines in [CONTRIBUTING.md](https://github.com/aws/aws-toolkit-vscode/blob/master/CONTRIBUTING.md#guidelines). - License: I confirm that my contribution is made under the terms of the Apache 2.0 license. Co-authored-by: aws-toolkit-automation <[email protected]> Co-authored-by: Roger Zhang <[email protected]> Co-authored-by: Reed Hamilton <[email protected]> Co-authored-by: Jacob Chung <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Solution
feature/xbranches will not be squash-merged at release time.