Skip to content

Conversation

@Will-ShaoHua
Copy link
Contributor

@Will-ShaoHua Will-ShaoHua commented Jul 7, 2025

Problem

It's confusing when Q is saying it's thinking however sometimes the model returns empty suggestion thus nothing will be displayed to users. Thus the team decides to remove the UI.

Solution


  • Treat all work as PUBLIC. Private feature/x branches will not be squash-merged at release time.
  • Your code changes must meet the guidelines in CONTRIBUTING.md.
  • License: I confirm that my contribution is made under the terms of the Apache 2.0 license.

@Will-ShaoHua Will-ShaoHua requested a review from a team as a code owner July 7, 2025 20:58
@github-actions
Copy link

github-actions bot commented Jul 7, 2025

  • This pull request implements a feat or fix, so it must include a changelog entry (unless the fix is for an unreleased feature). Review the changelog guidelines.
    • Note: beta or "experiment" features that have active users should announce fixes in the changelog.
    • If this is not a feature or fix, use an appropriate type from the title guidelines. For example, telemetry-only changes should use the telemetry type.

@Will-ShaoHua
Copy link
Contributor Author

/retryBuilds

@Will-ShaoHua
Copy link
Contributor Author

) AppBuilder Walkthrough
Create project
start with an existing template
override existing template
download serverlessland proj:
Error: Test length exceeded max duration: 30 seconds

@atonaamz
Copy link
Contributor

atonaamz commented Jul 7, 2025

One of the required test is failing

@Will-ShaoHua
Copy link
Contributor Author

/retryBuilds

@Will-ShaoHua
Copy link
Contributor Author

Will-ShaoHua commented Jul 7, 2025

One of the required test is failing

feel the test is flaky

@leigaol leigaol merged commit 01850cd into aws:master Jul 8, 2025
30 of 31 checks passed
@Will-ShaoHua
Copy link
Contributor Author

3531 passing (5m)
  14 pending
  1 failing
  1) AppBuilder Walkthrough
       Create project
         start with an existing template
           override existing template
             download serverlessland proj:
     Error: Test length exceeded max duration: 30 seconds
[No Pending UI Elements Found]
      at Timeout._onTimeout (/Users/runner/work/aws-toolkit-vscode/aws-toolkit-vscode/packages/core/src/test/setupUtil.ts:46:32)
      at listOnTimeout (node:internal/timers:588:17)
      at processTimers (node:internal/timers:523:7)

@Will-ShaoHua Will-ShaoHua deleted the ui branch July 8, 2025 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants