Skip to content

Conversation

@rhamilt
Copy link
Contributor

@rhamilt rhamilt commented Jul 8, 2025

fixes #7618

Problem

Introduced in #7601 is a bug where choosing to upload a Lambda function from a directory would not allow the user to actually select the directory. In the directory selection window, the button to select is disabled. This was an inadvertent change when adding new functionality.

Solution

Revert the breaking change. In addition to switching canSelectFolders to true and canSelectFiles to false, I have reverted the other changes in the upload flow that were added in the original PR. This is because these changes added another flow to the upload modal that doesn't fit with all the other added functionality, and just increases the complexity of the code without much benefit. Because this was the only place that used the lambdaEdits array from the utils, I removed that as well.


  • Treat all work as PUBLIC. Private feature/x branches will not be squash-merged at release time.
  • Your code changes must meet the guidelines in CONTRIBUTING.md.
  • License: I confirm that my contribution is made under the terms of the Apache 2.0 license.

@rhamilt rhamilt requested a review from a team as a code owner July 8, 2025 22:55
@github-actions
Copy link

github-actions bot commented Jul 8, 2025

  • This pull request implements a feat or fix, so it must include a changelog entry (unless the fix is for an unreleased feature). Review the changelog guidelines.
    • Note: beta or "experiment" features that have active users should announce fixes in the changelog.
    • If this is not a feature or fix, use an appropriate type from the title guidelines. For example, telemetry-only changes should use the telemetry type.

Copy link
Member

@roger-zhangg roger-zhangg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@laileni-aws laileni-aws merged commit 9cf9bdd into aws:master Jul 11, 2025
30 of 31 checks passed
@rhamilt rhamilt deleted the uploadLambdaFix branch July 17, 2025 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

AWS Toolkit 3.68.0 lambda folder upload unactive

5 participants