Skip to content

Conversation

@Will-ShaoHua
Copy link
Contributor

@Will-ShaoHua Will-ShaoHua commented Jul 11, 2025

Problem

GenerateCompletion will wait until "ALL" pages are finished and then return. It's supposed to return the first response immediately when it arrives and push/update the remaining suggestions afterward.

Solution

Revert partial unintended changes made in 9bd9d99#diff-5d07606815c684624bb1c126f4e0da3df22fb2b89be24564d203a8b78fd3c1adL92-L107


  • Treat all work as PUBLIC. Private feature/x branches will not be squash-merged at release time.
  • Your code changes must meet the guidelines in CONTRIBUTING.md.
  • License: I confirm that my contribution is made under the terms of the Apache 2.0 license.

@Will-ShaoHua Will-ShaoHua requested a review from a team as a code owner July 11, 2025 20:27
@github-actions
Copy link

  • This pull request modifies code in src/* but no tests were added/updated.
    • Confirm whether tests should be added or ensure the PR description explains why tests are not required.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant