Skip to content

Conversation

@atonaamz
Copy link
Contributor

Problem

Solution


  • Treat all work as PUBLIC. Private feature/x branches will not be squash-merged at release time.
  • Your code changes must meet the guidelines in CONTRIBUTING.md.
  • License: I confirm that my contribution is made under the terms of the Apache 2.0 license.

@atonaamz atonaamz requested a review from a team as a code owner July 11, 2025 22:56
@github-actions
Copy link

  • This pull request modifies code in src/* but no tests were added/updated.
    • Confirm whether tests should be added or ensure the PR description explains why tests are not required.
  • This pull request implements a feat or fix, so it must include a changelog entry (unless the fix is for an unreleased feature). Review the changelog guidelines.
    • Note: beta or "experiment" features that have active users should announce fixes in the changelog.
    • If this is not a feature or fix, use an appropriate type from the title guidelines. For example, telemetry-only changes should use the telemetry type.

{ emitTelemetry: false, showUi: false, editsStreakToken: session.editsStreakPartialResultToken }
)
}
session.triggerOnAcceptance = true
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit

if (isInlineEdit) {
   session.triggerOnAcceptance = true
}

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This code path in displayImage.ts always belongs to EDITS

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh good callout

@atonaamz atonaamz changed the title fix: should pass nextToken to Flare for Edits on acceptance without calling provideInlineCompletionItems fix(amazonq): should pass nextToken to Flare for Edits on acceptance without calling provideInlineCompletionItems Jul 11, 2025
@atonaamz atonaamz closed this Jul 11, 2025
@atonaamz atonaamz reopened this Jul 11, 2025
@atonaamz atonaamz enabled auto-merge July 11, 2025 23:15
@atonaamz atonaamz merged commit d1959b9 into aws:master Jul 11, 2025
28 of 29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants