Skip to content

Conversation

@dungdong-aws
Copy link
Contributor

Problem

Currently, users need to manually click buttons or use the command palette to execute common shell
commands (reject/run/stop) in the IDE. This creates friction in the developer workflow, especially
for power users who prefer keyboard shortcuts.

Solution

Reopen Na's PR that added keyboard shortcuts for reject/run/stop shell commands

Update to align with new requirements.

Add VS Code feature flag (shortcut)

Screenshots

Screen.Recording.2025-07-13.at.10.55.44.AM.mov

  • Treat all work as PUBLIC. Private feature/x branches will not be squash-merged at release time.
  • Your code changes must meet the guidelines in CONTRIBUTING.md.
  • License: I confirm that my contribution is made under the terms of the Apache 2.0 license.

@dungdong-aws dungdong-aws requested a review from a team as a code owner July 13, 2025 19:47
@github-actions
Copy link

  • This pull request modifies code in src/* but no tests were added/updated.
    • Confirm whether tests should be added or ensure the PR description explains why tests are not required.
  • This pull request implements a feat or fix, so it must include a changelog entry (unless the fix is for an unreleased feature). Review the changelog guidelines.
    • Note: beta or "experiment" features that have active users should announce fixes in the changelog.
    • If this is not a feature or fix, use an appropriate type from the title guidelines. For example, telemetry-only changes should use the telemetry type.

@dungdong-aws dungdong-aws changed the title feat: add keybinding shortcut for stop/reject/run shell commands feat(amazonq): add keybinding shortcut for stop/reject/run shell commands Jul 13, 2025
@dungdong-aws dungdong-aws reopened this Jul 13, 2025
}

function registerShellCommandShortCut(commandName: string, buttonId: string, provider: AmazonQChatViewProvider) {
return Commands.register(commandName, async () => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit:
Not a blocking One.
We can add a log here which helps us to debug the issues.

{
"command": "aws.amazonq.stopCmdExecution",
"title": "Stop Amazon Q Command Execution",
"category": "%AWS.amazonq.title%"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the stop shortcut will also used for global stop, right? if yes, then we should change the title. IMO

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, but regular prompt without tool execution can be still considered as Q Command right?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure why no tool execution can be considered Q command stop / run / reject?

@laileni-aws laileni-aws reopened this Jul 14, 2025
@laileni-aws laileni-aws requested a review from yueny2020 July 14, 2025 23:11
@dungdong-aws dungdong-aws reopened this Jul 15, 2025
@ashishrp-aws ashishrp-aws merged commit 028f4f3 into aws:master Jul 15, 2025
42 of 47 checks passed
}
},
"aws-schemas-registry": {
"aws-sagemaker-code-editor": {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why this changed?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it was because of npm install not sure why, I reverted it, then the next npm install will change this

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the catch na

}
},
"aws-stepfunctions-preview": {
"aws-schemas-registry": {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yueny2020 got added here after npm install run for dependencies.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants