-
Notifications
You must be signed in to change notification settings - Fork 746
feat(amazonq): add keybinding shortcut for stop/reject/run shell commands #7655
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
| } | ||
|
|
||
| function registerShellCommandShortCut(commandName: string, buttonId: string, provider: AmazonQChatViewProvider) { | ||
| return Commands.register(commandName, async () => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit:
Not a blocking One.
We can add a log here which helps us to debug the issues.
| { | ||
| "command": "aws.amazonq.stopCmdExecution", | ||
| "title": "Stop Amazon Q Command Execution", | ||
| "category": "%AWS.amazonq.title%" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the stop shortcut will also used for global stop, right? if yes, then we should change the title. IMO
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, but regular prompt without tool execution can be still considered as Q Command right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not sure why no tool execution can be considered Q command stop / run / reject?
| } | ||
| }, | ||
| "aws-schemas-registry": { | ||
| "aws-sagemaker-code-editor": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why this changed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it was because of npm install not sure why, I reverted it, then the next npm install will change this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for the catch na
| } | ||
| }, | ||
| "aws-stepfunctions-preview": { | ||
| "aws-schemas-registry": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@yueny2020 got added here after npm install run for dependencies.
Problem
Currently, users need to manually click buttons or use the command palette to execute common shell
commands (reject/run/stop) in the IDE. This creates friction in the developer workflow, especially
for power users who prefer keyboard shortcuts.
Solution
Reopen Na's PR that added keyboard shortcuts for reject/run/stop shell commands
Update to align with new requirements.
Add VS Code feature flag (shortcut)
Screenshots
Screen.Recording.2025-07-13.at.10.55.44.AM.mov
feature/xbranches will not be squash-merged at release time.