Skip to content

Conversation

@yuxianrz
Copy link

@yuxianrz yuxianrz commented Jul 14, 2025

Problem

The webview does not support IAM credentials input and endpoint to LSP does not support IAM credentials and IAM profiles.

Solution

This is part of #7507.

  • Add IAM credentials option and form to webview
  • Modify AuthUtils to switch between SsoLogin and IamLogin strategies
  • Add startIamCredentialSetup in backend_amazonq

Meanwhile, we are making changes to language-servers and language-server-runtimes such that authentication for IAM credentials can happen on Flare side.

working branches:
https://github.com/liramon1/language-server-runtimes/tree/feature/flare-iam
https://github.com/liramon1/language-servers/tree/liramon/flare-iam

Current PR built upon flare-mega branch and is working to merge with flare-mega branch. This PR fails a web test that flare-mega branch is also failing, at the same place.


  • License: I confirm that my contribution is made under the terms of the Apache 2.0 license.

@yuxianrz yuxianrz requested review from a team as code owners July 14, 2025 06:23
@github-actions
Copy link

  • This pull request implements a feat or fix, so it must include a changelog entry (unless the fix is for an unreleased feature). Review the changelog guidelines.
    • Note: beta or "experiment" features that have active users should announce fixes in the changelog.
    • If this is not a feature or fix, use an appropriate type from the title guidelines. For example, telemetry-only changes should use the telemetry type.

@laileni-aws
Copy link
Contributor

/retryBuilds

@yuxianrz yuxianrz force-pushed the feature/iam-login branch from 72543d0 to cee61d3 Compare July 21, 2025 18:06
@yuxianrz yuxianrz requested review from ctlai95 and leigaol July 24, 2025 18:53
@ctlai95
Copy link
Contributor

ctlai95 commented Jul 25, 2025

Please check why some tests are failing

@ashishrp-aws
Copy link
Contributor

/retryBuilds

@tsmithsz tsmithsz closed this Jul 31, 2025
@tsmithsz tsmithsz reopened this Jul 31, 2025
@bywang56 bywang56 merged commit 3ff9966 into aws:feature/flare-mega Jul 31, 2025
34 of 55 checks passed
bywang56 pushed a commit that referenced this pull request Aug 4, 2025
… autofill access key id (#7797)

## Problem
UI and error message no longer compatible after adding IAM credentials
authflow
IAM Access Key needs manual input every time a client log in

## Solution
This is part of #7507 and
is built on top of #7659.

---

- License: I confirm that my contribution is made under the terms of the
Apache 2.0 license.

---------

Co-authored-by: Ramon Li <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants