fix(sagemaker): fix sagemaker.parseCookies cmd not found #7670
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
yueny2020
force-pushed
the
ynsagemakerfix
branch
from
bc021f9 to
531270e
Compare
ashishrp-aws
approved these changes
Jul 15, 2025
laileni-aws
approved these changes
Jul 15, 2025
yueny2020
force-pushed
the
ynsagemakerfix
branch
from
531270e to
2eb37d4
Compare
arkaprava08
approved these changes
Jul 15, 2025
Contributor
arkaprava08
left a comment
arkaprava08
left a comment
There was a problem hiding this comment.
LGTM. Tested in remoteIDE environment
edwardps
reviewed
Jul 15, 2025
packages/core/src/auth/activation.ts
Outdated
| initializeCredentialsProviderManager() | ||
| } | ||
| } catch (e) { | ||
| getLogger().warn(`Failed to execute command "sagemaker.parseCookies": ${e}`) |
There was a problem hiding this comment.
We cannot assume all exceptions come from "sagemaker.parseCookies".
Please consider conditionally ignore the exception only for "sagemaker.parseCookies" issue. For other exceptions, we still need to throw the exception.
yueny2020
force-pushed
the
ynsagemakerfix
branch
from
2eb37d4 to
f0a475d
Compare
|
Please add some UT and I can approve this PR. |
Contributor
Author
i will add ut in a follow up pr, and ask you to review. and for now i will merge the pr. |
|
UT is in another PR. |
yueny2020
added a commit
that referenced
this pull request
Jul 17, 2025
## Problem This pr: #7670 didn't been covered by the unit test ## Solution Add unit test for the activation initialize method. --- - Treat all work as PUBLIC. Private `feature/x` branches will not be squash-merged at release time. - Your code changes must meet the guidelines in [CONTRIBUTING.md](https://github.com/aws/aws-toolkit-vscode/blob/master/CONTRIBUTING.md#guidelines). - License: I confirm that my contribution is made under the terms of the Apache 2.0 license.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
After Remote - SSH to a sagemaker space via VS Code, the amazon Q plugin cannot be loaded for the following error.
Solution
After discussed with the Sagemaker team folks @sunp and @arkaprav, we decide that if cmd
sagemaker.parseCookiesnot found, we just swallow the error and add a log for it.Test
a local build is created for testing.
feature/xbranches will not be squash-merged at release time.