-
Notifications
You must be signed in to change notification settings - Fork 746
fix(sagemaker): Fix race-condition with multiple remote spaces trying to reconnect #7684
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
packages/core/src/test/awsService/sagemaker/detached-server/utils.test.ts
Show resolved
Hide resolved
|
Need to generate a changelog entry with |
| } | ||
|
|
||
| writeQueue.push(writeOperation) | ||
| processWriteQueue().catch(reject) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
processWriteQueue().catch this catch cannot catch anything because inside processWriteQueue it does not throw.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, I’ll remove this. Since processWriteQueue uses a try/finally block there's nothing to catch, and writeOperation already handles errors and calls reject.
Problem
Solution
remote_access_token_refreshflag to the refresh URL to enable the Studio server to return more specific error messages.feature/xbranches will not be squash-merged at release time.