Skip to content

Conversation

@abhraina-aws
Copy link
Contributor

@abhraina-aws abhraina-aws commented Jul 23, 2025

Problem

Needed to add a new drop down show logs button at the top. Having just a web view button would lead to this functionality not work incase the LS doesnt work.

Solution

Added the same show logs functionality in the top drop down.
image


  • Treat all work as PUBLIC. Private feature/x branches will not be squash-merged at release time.
  • Your code changes must meet the guidelines in CONTRIBUTING.md.
  • License: I confirm that my contribution is made under the terms of the Apache 2.0 license.

@abhraina-aws abhraina-aws requested review from a team as code owners July 23, 2025 22:45
@github-actions
Copy link

  • This pull request modifies code in src/* but no tests were added/updated.
    • Confirm whether tests should be added or ensure the PR description explains why tests are not required.
  • This pull request implements a feat or fix, so it must include a changelog entry (unless the fix is for an unreleased feature). Review the changelog guidelines.
    • Note: beta or "experiment" features that have active users should announce fixes in the changelog.
    • If this is not a feature or fix, use an appropriate type from the title guidelines. For example, telemetry-only changes should use the telemetry type.

},
{
"command": "aws.amazonq.showLogs",
"when": "view == aws.amazonq.AmazonQChatView",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we show this for SageMakerUnifiedStudio ?

{ id: 'aws.amazonq.showLogs', compositeKey: { 1: 'source' } },
() => async (_: VsCodeCommandArg, source: CodeWhispererSource) => {
if (_ !== placeholder) {
source = 'ellipsesMenu'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit:
Whats this ellipsesMenu?

@abhraina-aws abhraina-aws merged commit 9128f47 into aws:master Jul 24, 2025
59 of 62 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants